Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-24 Thread Markus Armbruster
Markus Armbruster writes: > Marc-André Lureau writes: > >> Use qlit_ prefix. > > Let's spell it out: > > qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() > > By the way, not only is your name shorter, it's also more precise: > "compare" suggests -1, 0, +1 for less than, equal

Re: [Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-24 Thread Markus Armbruster
Marc-André Lureau writes: > Use qlit_ prefix. Let's spell it out: qlit: rename compare_litqobj_to_qobj() to qlit_equal_qobject() By the way, not only is your name shorter, it's also more precise: "compare" suggests -1, 0, +1 for less than, equal and greater than, equal suggests non-zero f

[Qemu-devel] [PATCH 05/14] qlit: rename compare_litqobj_to_qobj

2017-08-24 Thread Marc-André Lureau
Use qlit_ prefix. Signed-off-by: Marc-André Lureau --- include/qapi/qmp/qlit.h | 2 +- qobject/qlit.c | 6 +++--- tests/check-qjson.c | 14 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/qapi/qmp/qlit.h b/include/qapi/qmp/qlit.h index 1e969