Re: [Qemu-devel] [PATCH 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-19 Thread Fam Zheng
On Tue, 01/05 18:01, John Snow wrote: > Should we skip adding the typedef for HBitmapIter if we're just going to > use this instead? Yes, we can clean this up. > > On 01/04/2016 05:27 AM, Fam Zheng wrote: > > HBitmap is an implementation detail of block dirty bitmap that should be > > hidden >

Re: [Qemu-devel] [PATCH 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-05 Thread John Snow
Should we skip adding the typedef for HBitmapIter if we're just going to use this instead? On 01/04/2016 05:27 AM, Fam Zheng wrote: > HBitmap is an implementation detail of block dirty bitmap that should be > hidden > from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying > HBi

[Qemu-devel] [PATCH 05/13] block: Hide HBitmap in block dirty bitmap interface

2016-01-04 Thread Fam Zheng
HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitmapIter must be dyn