Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-17 Thread Stefan Hajnoczi
On Tue, Nov 17, 2015 at 11:10:26AM +0300, Denis V. Lunev wrote: > On 11/17/2015 10:22 AM, Stefan Hajnoczi wrote: > >On Mon, Nov 16, 2015 at 06:24:36PM +0300, Denis V. Lunev wrote: > >>@@ -2168,21 +2157,7 @@ void hmp_info_snapshots(Monitor *mon, const QDict > >>*qdict) > >> available_snapshots

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-17 Thread Denis V. Lunev
On 11/17/2015 10:22 AM, Stefan Hajnoczi wrote: On Mon, Nov 16, 2015 at 06:24:36PM +0300, Denis V. Lunev wrote: +int bdrv_all_find_snapshot(const char *name, bool skip_read_only, + BlockDriverState **first_bad_bs) +{ +QEMUSnapshotInfo sn; +int err = 0; +Block

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 06:24:36PM +0300, Denis V. Lunev wrote: > +int bdrv_all_find_snapshot(const char *name, bool skip_read_only, > + BlockDriverState **first_bad_bs) > +{ > +QEMUSnapshotInfo sn; > +int err = 0; > +BlockDriverState *bs = NULL; > + > +whi

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Stefan Hajnoczi
On Tue, Nov 10, 2015 at 05:25:30PM +0300, Denis V. Lunev wrote: > +int bdrv_all_find_snapshot(const char *name, bool read_only, > + BlockDriverState **first_bad_bs) > +{ > +QEMUSnapshotInfo sn; > +int err = 0; > +BlockDriverState *bs = NULL; > + > +while (e

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Denis V. Lunev
On 11/16/2015 12:31 PM, Stefan Hajnoczi wrote: On Tue, Nov 10, 2015 at 05:25:30PM +0300, Denis V. Lunev wrote: +int bdrv_all_find_snapshot(const char *name, bool read_only, + BlockDriverState **first_bad_bs) +{ +QEMUSnapshotInfo sn; +int err = 0; +BlockDrive

[Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Denis V. Lunev
to check that snapshot is available for all loaded block drivers. The ability to switch to snapshot is verified separately using bdrv_all_can_snapshot. The patch also ensures proper locking. Signed-off-by: Denis V. Lunev Reviewed-by: Fam Zheng CC: Juan Quintela CC: Stefan Hajnoczi CC: Kevin W

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-16 Thread Denis V. Lunev
On 11/16/2015 12:31 PM, Stefan Hajnoczi wrote: On Tue, Nov 10, 2015 at 05:25:30PM +0300, Denis V. Lunev wrote: +int bdrv_all_find_snapshot(const char *name, bool read_only, + BlockDriverState **first_bad_bs) +{ +QEMUSnapshotInfo sn; +int err = 0; +BlockDrive

[Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-10 Thread Denis V. Lunev
to check that snapshot is available for all loaded block drivers. The ability to switch to snapshot is verified separately using bdrv_all_can_snapshot. The patch also ensures proper locking. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Stefan Hajnoczi CC: Kevin Wolf --- block/snapshot

Re: [Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-09 Thread Stefan Hajnoczi
On Sat, Nov 07, 2015 at 06:54:55PM +0300, Denis V. Lunev wrote: This: > +int bdrv_all_find_snapshot(const char *name, BlockDriverState **first_bad_bs) > +{ > +QEMUSnapshotInfo sn; > +int err = 0; > +BlockDriverState *bs = NULL; > + > +while (err == 0 && (bs = bdrv_next(bs))) { > +

[Qemu-devel] [PATCH 05/10] snapshot: create bdrv_all_find_snapshot helper

2015-11-07 Thread Denis V. Lunev
to check that snapshot is available for all loaded block drivers. The ability to switch to snapshot is verified separately using bdrv_all_can_snapshot. The patch also ensures proper locking. Signed-off-by: Denis V. Lunev CC: Juan Quintela CC: Stefan Hajnoczi CC: Kevin Wolf --- block/snapshot