On 04/11/2017 12:57 AM, Paolo Bonzini wrote:
>
>
> On 11/04/2017 00:05, John Snow wrote:
>>
>>
>> On 04/08/2017 05:52 AM, Paolo Bonzini wrote:
>>>
>>>
>>> On 08/04/2017 08:03, John Snow wrote:
Looks clean, though it may be useful to do a few more things;
- Demarcate what you thin
On 11/04/2017 00:05, John Snow wrote:
>
>
> On 04/08/2017 05:52 AM, Paolo Bonzini wrote:
>>
>>
>> On 08/04/2017 08:03, John Snow wrote:
>>> Looks clean, though it may be useful to do a few more things;
>>>
>>> - Demarcate what you think is the monitor API in this file
>>
>> It's already there:
On 04/08/2017 05:52 AM, Paolo Bonzini wrote:
>
>
> On 08/04/2017 08:03, John Snow wrote:
>> Looks clean, though it may be useful to do a few more things;
>>
>> - Demarcate what you think is the monitor API in this file
>
> It's already there:
>
> +/*
> + * API for block job drivers and the bl
On Thu, Mar 23, 2017 at 06:39:23PM +0100, Paolo Bonzini wrote:
> We already have different locking policies for APIs called by the monitor
> and the block job. Monitor APIs need consistency across block_job_get
> and the actual operation (e.g. block_job_set_speed), so currently there
> are explici
On 08/04/2017 08:03, John Snow wrote:
> Looks clean, though it may be useful to do a few more things;
>
> - Demarcate what you think is the monitor API in this file
It's already there:
+/*
+ * API for block job drivers and the block layer.
+ */
+
where everything before is for the monitor.
>
On 03/23/2017 01:39 PM, Paolo Bonzini wrote:
> We already have different locking policies for APIs called by the monitor
> and the block job. Monitor APIs need consistency across block_job_get
> and the actual operation (e.g. block_job_set_speed), so currently there
> are explicit aio_context_ac
We already have different locking policies for APIs called by the monitor
and the block job. Monitor APIs need consistency across block_job_get
and the actual operation (e.g. block_job_set_speed), so currently there
are explicit aio_context_acquire/release calls in blockdev.c.
When a block job ne
