Re: [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-15 Thread Kevin Wolf
Am 15.08.2018 um 22:52 hat John Snow geschrieben: > On 08/08/2018 12:29 PM, Kevin Wolf wrote: > > Am 07.08.2018 um 06:33 hat John Snow geschrieben: > >> Change the manual deferment to commit_complete into the implicit > >> callback to job_exit. > >> > >> Signed-off-by: John Snow > > > > There is

Re: [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-15 Thread John Snow
On 08/08/2018 12:29 PM, Kevin Wolf wrote: > Am 07.08.2018 um 06:33 hat John Snow geschrieben: >> Change the manual deferment to commit_complete into the implicit >> callback to job_exit. >> >> Signed-off-by: John Snow > > There is one tricky thing in this patch that the commit message could be

Re: [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-08 Thread Kevin Wolf
Am 07.08.2018 um 06:33 hat John Snow geschrieben: > Change the manual deferment to commit_complete into the implicit > callback to job_exit. > > Signed-off-by: John Snow There is one tricky thing in this patch that the commit message could be a bit more explicit about, which is moving job_comple

Re: [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-08 Thread John Snow
On 08/07/2018 11:41 PM, Jeff Cody wrote: > On Tue, Aug 07, 2018 at 12:33:32AM -0400, John Snow wrote: >> Change the manual deferment to commit_complete into the implicit >> callback to job_exit. >> >> Signed-off-by: John Snow >> --- >> block/commit.c | 19 +-- >> 1 file changed

Re: [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-07 Thread Jeff Cody
On Tue, Aug 07, 2018 at 12:33:32AM -0400, John Snow wrote: > Change the manual deferment to commit_complete into the implicit > callback to job_exit. > > Signed-off-by: John Snow > --- > block/commit.c | 19 +-- > 1 file changed, 5 insertions(+), 14 deletions(-) > > diff --git a

[Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim

2018-08-06 Thread John Snow
Change the manual deferment to commit_complete into the implicit callback to job_exit. Signed-off-by: John Snow --- block/commit.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/block/commit.c b/block/commit.c index 620666161b..5bed098d5f 100644 --- a/bl