Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-06-02 Thread Marc-André Lureau
Hi On Fri, Jun 2, 2017 at 10:30 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Tue, May 30, 2017 at 6:23 PM Markus Armbruster > wrote: > > > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > On Thu, May 11, 2017 at 6:30 PM Markus Armbruster > wrote: > [..

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-06-01 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, May 30, 2017 at 6:23 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Thu, May 11, 2017 at 6:30 PM Markus Armbruster >> > wrote: [...] >> >> g_assert_not_reached() is problematic, see "[PATCH] checkpatch: Disallow >>

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-30 Thread Marc-André Lureau
Hi On Tue, May 30, 2017 at 6:23 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Thu, May 11, 2017 at 6:30 PM Markus Armbruster > wrote: > > > >> Marc-André Lureau writes: > >> > >> > >> > + * > >> > + * This work is licensed under the terms of the GNU LGPL, version

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-30 Thread Eric Blake
On 05/30/2017 02:32 AM, Marc-André Lureau wrote: > Hi > > On Thu, May 11, 2017 at 6:30 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> >>> + * >>> + * This work is licensed under the terms of the GNU LGPL, version 2.1 >> or later. >>> + * See the COPYING.LIB file in the top-lev

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-30 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, May 11, 2017 at 6:30 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> >> > + * >> > + * This work is licensed under the terms of the GNU LGPL, version 2.1 or >> > later. >> > + * See the COPYING.LIB file in the top-level directory. >>

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-30 Thread Marc-André Lureau
Hi On Thu, May 11, 2017 at 6:30 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > > + * > > + * This work is licensed under the terms of the GNU LGPL, version 2.1 > or later. > > + * See the COPYING.LIB file in the top-level directory. > > + */ > > + > > +#ifndef QNUM_H > > +#define

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 12 May 2017 08:30:36 +0200 > Markus Armbruster wrote: > >> Question for Luiz... >> >> Marc-André Lureau writes: >> >> [...] >> > diff --git a/tests/check-qnum.c b/tests/check-qnum.c >> > new file mode 100644 >> > index 00..d08d35e85a >> > --- /dev/nul

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-14 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 12 May 2017 09:37:50 +0200 > Markus Armbruster wrote: > >> Luiz, there's a lone question for you further down. Search for your >> name. > > I could not a question, can you paste it here? Uh, I actually spun it out into its own message, so you don't have to wad

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-12 Thread Luiz Capitulino
On Fri, 12 May 2017 09:37:50 +0200 Markus Armbruster wrote: > Luiz, there's a lone question for you further down. Search for your > name. I could not a question, can you paste it here? > > Marc-André Lureau writes: > > > We would like to use a same QObject type to represent numbers, whether

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-12 Thread Luiz Capitulino
On Fri, 12 May 2017 08:30:36 +0200 Markus Armbruster wrote: > Question for Luiz... > > Marc-André Lureau writes: > > [...] > > diff --git a/tests/check-qnum.c b/tests/check-qnum.c > > new file mode 100644 > > index 00..d08d35e85a > > --- /dev/null > > +++ b/tests/check-qnum.c > > @@ -0

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-12 Thread Markus Armbruster
Luiz, there's a lone question for you further down. Search for your name. Marc-André Lureau writes: > We would like to use a same QObject type to represent numbers, whether > they are int, uint, or floats. getters will allow some compatibility > between the various types if the number fits othe

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-11 Thread Markus Armbruster
Question for Luiz... Marc-André Lureau writes: [...] > diff --git a/tests/check-qnum.c b/tests/check-qnum.c > new file mode 100644 > index 00..d08d35e85a > --- /dev/null > +++ b/tests/check-qnum.c > @@ -0,0 +1,131 @@ > +/* > + * QNum unit-tests. > + * > + * Copyright (C) 2009 Red Hat Inc

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-11 Thread Eric Blake
On 05/11/2017 09:29 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> We would like to use a same QObject type to represent numbers, whether >> they are int, uint, or floats. getters will allow some compatibility > > Please start your sentence with a capital letter ... > >> between

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-11 Thread Markus Armbruster
Marc-André Lureau writes: > We would like to use a same QObject type to represent numbers, whether > they are int, uint, or floats. getters will allow some compatibility Please start your sentence with a capital letter ... > between the various types if the number fits other representations ..

[Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-09 Thread Marc-André Lureau
We would like to use a same QObject type to represent numbers, whether they are int, uint, or floats. getters will allow some compatibility between the various types if the number fits other representations Signed-off-by: Marc-André Lureau --- scripts/qapi.py | 30 +++--