Re: [Qemu-devel] [PATCH 04/14] timer: ds1338 clarify HOUR handling

2018-07-08 Thread David Gibson
On Thu, Jul 05, 2018 at 11:19:51AM -0700, Michael Davidsaver wrote: > Simplify and comment the translation between > registers and struct tm. > > Signed-off-by: Michael Davidsaver Reviewed-by: David Gibson although.. [snip] > @@ -101,7 +105,9 @@ static void capture_current_time(DS1338State *s

[Qemu-devel] [PATCH 04/14] timer: ds1338 clarify HOUR handling

2018-07-05 Thread Michael Davidsaver
Simplify and comment the translation between registers and struct tm. Signed-off-by: Michael Davidsaver --- hw/timer/ds1338.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index b56db5852e..637a0f4246 100644 --- a/hw/

Re: [Qemu-devel] [PATCH 04/14] timer: ds1338 clarify HOUR handling

2018-04-12 Thread Peter Maydell
On 24 March 2018 at 19:24, Michael Davidsaver wrote: > Simplify and comment the translation between > registers and struct tm. > > Signed-off-by: Michael Davidsaver > --- > hw/timer/ds1338.c | 35 +-- > 1 file changed, 17 insertions(+), 18 deletions(-) > > diff --

[Qemu-devel] [PATCH 04/14] timer: ds1338 clarify HOUR handling

2018-03-24 Thread Michael Davidsaver
Simplify and comment the translation between registers and struct tm. Signed-off-by: Michael Davidsaver --- hw/timer/ds1338.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index 72a4692d60..9bcda26e