Re: [Qemu-devel] [PATCH 04/13] tcg/aarch64: enable dynamic TLB sizing

2019-01-25 Thread Richard Henderson
On 1/25/19 11:12 AM, Alex Bennée wrote: >> +if (table_ofs > 0xfff) { >> +int table_hi = table_ofs & ~0xfff; >> +int mask_hi = mask_ofs & ~0xfff; > > Isn't there a #define for this number here? No. I don't know what I'd call it, either. You're just Supposed to Know that arm me

Re: [Qemu-devel] [PATCH 04/13] tcg/aarch64: enable dynamic TLB sizing

2019-01-25 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 2 +- > tcg/aarch64/tcg-target.inc.c | 100 +-- > 2 files changed, 60 insertions(+), 42 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tc

[Qemu-devel] [PATCH 04/13] tcg/aarch64: enable dynamic TLB sizing

2019-01-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 +- tcg/aarch64/tcg-target.inc.c | 100 +-- 2 files changed, 60 insertions(+), 42 deletions(-) diff --git a/tcg/aarch64/tcg-target.h b/tcg/aarch64/tcg-target.h index 68868a27eb..5085a81060 100