Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 14:02, Michael S. Tsirkin ha scritto: > That's not too hard: we need two types that only > differ in the vmstate. > Use the correct one to create the device depending > on the pc type. > > Put in that light, we definitely did create new > devices while keeping old ones around for > c

Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-10 Thread Paolo Bonzini
Il 10/09/2014 14:20, Michael S. Tsirkin ha scritto: > > Do you have an example? I can think of one that we did in RHEL (hda) > > but it was never upstream. > > Well the whole PC machine is exactly like this, isn't it? Sorry, I cannot parse. You proposed creating two versions of pcspk that only

Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-10 Thread Michael S. Tsirkin
On Wed, Sep 10, 2014 at 12:59:35PM +0200, Paolo Bonzini wrote: > Il 10/09/2014 14:02, Michael S. Tsirkin ha scritto: > > That's not too hard: we need two types that only > > differ in the vmstate. > > Use the correct one to create the device depending > > on the pc type. > > > > Put in that light,

Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-10 Thread Michael S. Tsirkin
On Tue, Sep 09, 2014 at 03:28:43PM +0200, Paolo Bonzini wrote: > Il 09/09/2014 15:26, Juan Quintela ha scritto: > > Paolo Bonzini wrote: > >> From: Pavel Dovgalyuk > >> > >> VMState added by this patch preserves correct > >> loading of the PC speaker device state. > >> > >> This breaks migration

Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 15:26, Juan Quintela ha scritto: > Paolo Bonzini wrote: >> From: Pavel Dovgalyuk >> >> VMState added by this patch preserves correct >> loading of the PC speaker device state. >> >> This breaks migration to 2.1 and earlier. >> >> Signed-off-by: Pavel Dovgalyuk >> Signed-off-by: Pao

Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > VMState added by this patch preserves correct > loading of the PC speaker device state. > > This breaks migration to 2.1 and earlier. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Paolo Bonzini This should only be added for new machine typ

[Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk VMState added by this patch preserves correct loading of the PC speaker device state. This breaks migration to 2.1 and earlier. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --- hw/audio/pcspk.c | 16 ++-- 1 file changed, 14 insertions(+), 2 de