Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-31 Thread John Snow
On 05/30/2018 05:28 PM, Philippe Mathieu-Daudé wrote: > On 05/30/2018 05:17 PM, John Snow wrote: >> On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: >>> Hi John, >>> >>> On 05/25/2018 08:54 PM, John Snow wrote: A trace is added to let us watch unimplemented registers specifically,

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-30 Thread Philippe Mathieu-Daudé
On 05/30/2018 05:17 PM, John Snow wrote: > On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: >> Hi John, >> >> On 05/25/2018 08:54 PM, John Snow wrote: >>> A trace is added to let us watch unimplemented registers specifically, >>> as these are more likely to cause us trouble. Otherwise, the por

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-30 Thread John Snow
On 05/26/2018 12:44 AM, Philippe Mathieu-Daudé wrote: > Hi John, > > On 05/25/2018 08:54 PM, John Snow wrote: >> A trace is added to let us watch unimplemented registers specifically, >> as these are more likely to cause us trouble. Otherwise, the port read >> traces now tell us what register i

Re: [Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-25 Thread Philippe Mathieu-Daudé
Hi John, On 05/25/2018 08:54 PM, John Snow wrote: > A trace is added to let us watch unimplemented registers specifically, > as these are more likely to cause us trouble. Otherwise, the port read > traces now tell us what register is getting hit, which is nicer. > > Signed-off-by: John Snow > --

[Qemu-devel] [PATCH 03/16] ahci: make port read traces more descriptive

2018-05-25 Thread John Snow
A trace is added to let us watch unimplemented registers specifically, as these are more likely to cause us trouble. Otherwise, the port read traces now tell us what register is getting hit, which is nicer. Signed-off-by: John Snow --- hw/ide/ahci.c | 5 +++-- hw/ide/trace-events | 3 ++-