Re: [Qemu-devel] [PATCH 03/10] xics: Handle KVM ICP realize from the common code

2019-02-17 Thread David Gibson
On Fri, Feb 15, 2019 at 02:27:41PM +0100, Greg Kurz wrote: > On Fri, 15 Feb 2019 14:09:53 +0100 > Cédric Le Goater wrote: > > > On 2/15/19 2:03 PM, Greg Kurz wrote: > > > On Fri, 15 Feb 2019 13:54:02 +0100 > > > Cédric Le Goater wrote: > > > > > >> On 2/15/19 12:40 PM, Greg Kurz wrote: > >

Re: [Qemu-devel] [PATCH 03/10] xics: Handle KVM ICP realize from the common code

2019-02-15 Thread Cédric Le Goater
On 2/15/19 2:27 PM, Greg Kurz wrote: > On Fri, 15 Feb 2019 14:09:53 +0100 > Cédric Le Goater wrote: > >> On 2/15/19 2:03 PM, Greg Kurz wrote: >>> On Fri, 15 Feb 2019 13:54:02 +0100 >>> Cédric Le Goater wrote: >>> On 2/15/19 12:40 PM, Greg Kurz wrote: > The realization of KVM ICP cu

Re: [Qemu-devel] [PATCH 03/10] xics: Handle KVM ICP realize from the common code

2019-02-15 Thread Greg Kurz
On Fri, 15 Feb 2019 14:09:53 +0100 Cédric Le Goater wrote: > On 2/15/19 2:03 PM, Greg Kurz wrote: > > On Fri, 15 Feb 2019 13:54:02 +0100 > > Cédric Le Goater wrote: > > > >> On 2/15/19 12:40 PM, Greg Kurz wrote: > >>> The realization of KVM ICP currently follows the parent_realize logic, >

Re: [Qemu-devel] [PATCH 03/10] xics: Handle KVM ICP realize from the common code

2019-02-15 Thread Cédric Le Goater
On 2/15/19 2:03 PM, Greg Kurz wrote: > On Fri, 15 Feb 2019 13:54:02 +0100 > Cédric Le Goater wrote: > >> On 2/15/19 12:40 PM, Greg Kurz wrote: >>> The realization of KVM ICP currently follows the parent_realize logic, >>> which is a bit overkill here. Also we want to get rid of the KVM ICP >>> cl

Re: [Qemu-devel] [PATCH 03/10] xics: Handle KVM ICP realize from the common code

2019-02-15 Thread Greg Kurz
On Fri, 15 Feb 2019 13:54:02 +0100 Cédric Le Goater wrote: > On 2/15/19 12:40 PM, Greg Kurz wrote: > > The realization of KVM ICP currently follows the parent_realize logic, > > which is a bit overkill here. Also we want to get rid of the KVM ICP > > class. Explicitely call icp_kvm_realize() from

Re: [Qemu-devel] [PATCH 03/10] xics: Handle KVM ICP realize from the common code

2019-02-15 Thread Cédric Le Goater
On 2/15/19 12:40 PM, Greg Kurz wrote: > The realization of KVM ICP currently follows the parent_realize logic, > which is a bit overkill here. Also we want to get rid of the KVM ICP > class. Explicitely call icp_kvm_realize() from the base ICP realize > function. > > Note that ICPStateClass::paren

[Qemu-devel] [PATCH 03/10] xics: Handle KVM ICP realize from the common code

2019-02-15 Thread Greg Kurz
The realization of KVM ICP currently follows the parent_realize logic, which is a bit overkill here. Also we want to get rid of the KVM ICP class. Explicitely call icp_kvm_realize() from the base ICP realize function. Note that ICPStateClass::parent_realize is retained because powernv needs it. S