Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 07:47 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: We could also consider making WITH_TMP act as a normal field. Working on the whole state looks like a bit like a corner

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > >> We could also consider making WITH_TMP act as a normal field. > >> Working on the whole state looks like a bit like a corner case: > >> we have some stuff adjacent in the migration st

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: > >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: >> We could also consider making WITH_TMP act as a normal field. >> Working on the whole state looks like a bit like a corner case: >> we have some stuff adjacent in the migration stream, and we have >> to map it on multiple fields (and vice-

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > * H

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Halil Pasic
On 05/19/2017 04:55 PM, Dr. David Alan Gilbert wrote: > Dave > P.S. I'm out for about a week. Thanks for the info! Could you say something about our 'two devices two sections vs two devices one section' dilemma form PATCH 06/10 before leaving? I do not want to be pushy, but I'm also eager to mak

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-19 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> > >> > >> On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > As a pr

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-18 Thread Halil Pasic
On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: As a preparation for switching to a vmstate based migration let us i

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >> As a preparation for switching to a vmstate based migration let us > >> introduce vmstate entities (e.g. VMStateDescription) for the

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-09 Thread Halil Pasic
On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> As a preparation for switching to a vmstate based migration let us >> introduce vmstate entities (e.g. VMStateDescription) for the css entities >> to be migrated. Alongside some comments exp

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-09 Thread Halil Pasic
On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> As a preparation for switching to a vmstate based migration let us >> introduce vmstate entities (e.g. VMStateDescription) for the css entities >> to be migrated. Alongside some comments exp

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-08 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > As a preparation for switching to a vmstate based migration let us > introduce vmstate entities (e.g. VMStateDescription) for the css entities > to be migrated. Alongside some comments explaining or indicating the not > migration of certain members

[Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-05 Thread Halil Pasic
As a preparation for switching to a vmstate based migration let us introduce vmstate entities (e.g. VMStateDescription) for the css entities to be migrated. Alongside some comments explaining or indicating the not migration of certain members are introduced too. No changes in behavior, we just add