Re: [Qemu-devel] [PATCH 03/10] cpu: init vmstate for ticks and clock offset

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 15:25, Juan Quintela ha scritto: > Nack. > > This break migration when using with older machine types. The other way round---this was broken recently, the patch fixes it. Paolo > Several questions before I propose an alternative: > - are we this fields always needed (then why migr

Re: [Qemu-devel] [PATCH 03/10] cpu: init vmstate for ticks and clock offset

2014-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > Ticks and clock offset used by CPU timers have to be saved in vmstate. > But vmstate for these fields registered only in icount mode. > Missing registration leads to breaking the continuity when vmstate is loaded. > This patch introduces new initia

[Qemu-devel] [PATCH 03/10] cpu: init vmstate for ticks and clock offset

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk Ticks and clock offset used by CPU timers have to be saved in vmstate. But vmstate for these fields registered only in icount mode. Missing registration leads to breaking the continuity when vmstate is loaded. This patch introduces new initialization function which fixes thi