Re: [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

2017-02-16 Thread Markus Armbruster
Eric Blake writes: > On 02/14/2017 04:25 AM, Markus Armbruster wrote: >> Plenty of code relies on QemuOpt member @str not being null, including >> qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to >> qemu_opt_foreach(). >> > >> >> Assert member @str isn't null, so that misuse is

Re: [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

2017-02-14 Thread Eric Blake
On 02/14/2017 04:25 AM, Markus Armbruster wrote: > Plenty of code relies on QemuOpt member @str not being null, including > qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to > qemu_opt_foreach(). > > > Assert member @str isn't null, so that misuse is caught right away. > > Simpli

[Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null

2017-02-14 Thread Markus Armbruster
Plenty of code relies on QemuOpt member @str not being null, including qemu_opts_print(), qemu_opts_to_qdict(), and callbacks passed to qemu_opt_foreach(). Begs the question whether it can be null. Only opt_set() creates QemuOpt. It sets member @str to its argument @value. Passing null for @val