Re: [Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations

2014-05-28 Thread Kevin Wolf
Am 22.05.2014 um 17:50 hat Stefan Hajnoczi geschrieben: > On Wed, May 21, 2014 at 06:28:00PM +0200, Kevin Wolf wrote: > > @@ -2270,7 +2270,10 @@ int bdrv_commit(BlockDriverState *bs) > > } > > > > total_sectors = length >> BDRV_SECTOR_BITS; > > -buf = g_malloc(COMMIT_BUF_SECTORS * B

Re: [Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations

2014-05-22 Thread Stefan Hajnoczi
On Wed, May 21, 2014 at 06:28:00PM +0200, Kevin Wolf wrote: > @@ -2270,7 +2270,10 @@ int bdrv_commit(BlockDriverState *bs) > } > > total_sectors = length >> BDRV_SECTOR_BITS; > -buf = g_malloc(COMMIT_BUF_SECTORS * BDRV_SECTOR_SIZE); > + > +/* qemu_try_blockalign() for bs will ch

[Qemu-devel] [PATCH 02/20] block: Handle failure for potentially large allocations

2014-05-21 Thread Kevin Wolf
Some code in the block layer makes potentially huge allocations. Failure is not completely unexpected there, so avoid aborting qemu and handle out-of-memory situations gracefully. This patch addresses bounce buffer allocations in block.c. While at it, convert bdrv_commit() from plain g_malloc() to