Re: [Qemu-devel] [PATCH 02/11] qemu.py: Avoid dangerous arguments

2017-07-21 Thread Philippe Mathieu-Daudé
On 07/20/2017 01:28 PM, Lukáš Doktor wrote: The list object is mutable in python and potentially might modify other object's arguments when used as default argument. Reproducer: >>> vm1 = QEMUMachine("qemu") >>> vm2 = QEMUMachine("qemu") >>> vm1._wrapper.append("foo") >>> pri

Re: [Qemu-devel] [PATCH 02/11] qemu.py: Avoid dangerous arguments

2017-07-20 Thread Eduardo Habkost
On Thu, Jul 20, 2017 at 06:28:06PM +0200, Lukáš Doktor wrote: > The list object is mutable in python and potentially might modify other > object's arguments when used as default argument. Reproducer: > > >>> vm1 = QEMUMachine("qemu") > >>> vm2 = QEMUMachine("qemu") > >>> vm1._wrapper.a

[Qemu-devel] [PATCH 02/11] qemu.py: Avoid dangerous arguments

2017-07-20 Thread Lukáš Doktor
The list object is mutable in python and potentially might modify other object's arguments when used as default argument. Reproducer: >>> vm1 = QEMUMachine("qemu") >>> vm2 = QEMUMachine("qemu") >>> vm1._wrapper.append("foo") >>> print vm2._wrapper ['foo'] In this case the `arg