Re: [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize

2015-03-29 Thread Paolo Bonzini
On 28/03/2015 19:58, Michael S. Tsirkin wrote: >> > +void memory_region_ram_resize(MemoryRegion *mr, ram_addr_t newsize, Error >> > **errp) >> > +{ >> > +assert(mr->terminates); > Why? Does "terminates" guarantee that ram_addr > is valid? In any case, I think this needs a comment. More or l

Re: [Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize

2015-03-28 Thread Michael S. Tsirkin
On Thu, Mar 26, 2015 at 06:38:19PM +0100, Paolo Bonzini wrote: > This is a simple MemoryRegion wrapper for qemu_ram_resize. > > Cc: Michael S. Tsirkin > Signed-off-by: Paolo Bonzini > --- > include/exec/memory.h | 12 > memory.c | 7 +++ > 2 files changed, 19 inse

[Qemu-devel] [PATCH 01/22] memory: add memory_region_ram_resize

2015-03-26 Thread Paolo Bonzini
This is a simple MemoryRegion wrapper for qemu_ram_resize. Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 12 memory.c | 7 +++ 2 files changed, 19 insertions(+) diff --git a/include/exec/memory.h b/include/exec/memory.h index 06f