Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Peter Maydell
On 25 October 2013 14:01, Tom Musta wrote: > On 10/25/2013 6:55 AM, Peter Maydell wrote: >> On 24 October 2013 17:17, Tom Musta wrote: >>>- float32_is_denormal() returns true if the 32-bit floating point >>> number >>> is denormalized. >>>- float64_is_denormal() returns true if the 6

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Tom Musta
On 10/25/2013 6:44 AM, Peter Maydell wrote: On 25 October 2013 12:34, Alex Bennée wrote: Is it worth adding some sort of test into make check to defend these softfloat functions against unintentional breakage? It would certainly be worthwhile as soon as multiple arches use these functions as fl

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Alex Bennée
peter.mayd...@linaro.org writes: > On 25 October 2013 12:34, Alex Bennée wrote: >> Is it worth adding some sort of test into make check to defend these >> softfloat functions against unintentional breakage? It would certainly >> be worthwhile as soon as multiple arches use these functions as flo

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Tom Musta
Peter: Thanks for your feedback. Responses below. On 10/25/2013 6:55 AM, Peter Maydell wrote: On 24 October 2013 17:17, Tom Musta wrote: This patch adds routines to the softfloat library that are useful for the PowerPC VSX implementation. The routines are, however, not specific to PowerPC

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Peter Maydell
On 24 October 2013 17:17, Tom Musta wrote: > This patch adds routines to the softfloat library that are useful for > the PowerPC VSX implementation. The routines are, however, not specific > to PowerPC and are approprriate for softfloat. > > The following routines are added: > > - float32_is_de

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Peter Maydell
On 25 October 2013 12:34, Alex Bennée wrote: > Is it worth adding some sort of test into make check to defend these > softfloat functions against unintentional breakage? It would certainly > be worthwhile as soon as multiple arches use these functions as float > errors are often subtle and hard to

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-25 Thread Alex Bennée
tommu...@gmail.com writes: > This patch adds routines to the softfloat library that are useful for > the PowerPC VSX implementation. The routines are, however, not specific > to PowerPC and are approprriate for softfloat. Is it worth adding some sort of test into make check to defend these sof

Re: [Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-24 Thread Richard Henderson
On 10/24/2013 09:17 AM, Tom Musta wrote: > This patch adds routines to the softfloat library that are useful for > the PowerPC VSX implementation. The routines are, however, not specific > to PowerPC and are approprriate for softfloat. > > The following routines are added: > > - float32_is_den

[Qemu-devel] [PATCH 01/19] Add New softfloat Routines for VSX

2013-10-24 Thread Tom Musta
This patch adds routines to the softfloat library that are useful for the PowerPC VSX implementation. The routines are, however, not specific to PowerPC and are approprriate for softfloat. The following routines are added: - float32_is_denormal() returns true if the 32-bit floating point numb