Re: [Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation

2019-09-17 Thread Eric Blake
On 9/17/19 5:20 AM, Greg Kurz wrote: > error_setg() and error_propagate(), as well as their variants, cause > QEMU to terminate when called with &error_fatal or &error_abort. This > prevents to add hints since error_append_hint() isn't even called in s/to add/adding/ > this case. > > It means th

Re: [Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation

2019-09-17 Thread Cornelia Huck
On Tue, 17 Sep 2019 12:20:37 +0200 Greg Kurz wrote: > error_setg() and error_propagate(), as well as their variants, cause > QEMU to terminate when called with &error_fatal or &error_abort. This > prevents to add hints since error_append_hint() isn't even called in > this case. > > It means that

[Qemu-devel] [PATCH 01/17] error: Update error_append_hint()'s documentation

2019-09-17 Thread Greg Kurz
error_setg() and error_propagate(), as well as their variants, cause QEMU to terminate when called with &error_fatal or &error_abort. This prevents to add hints since error_append_hint() isn't even called in this case. It means that error_append_hint() should only be used with a local error object