Re: [Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity()

2015-10-05 Thread John Snow
On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 2 +- > include/block/block.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 4f7fc0d..6d14f5b 100644

Re: [Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity()

2015-09-15 Thread Eric Blake
On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- The commit message summary mentions a one-line "what" (good), but is lacking a body that says "why" (that is, what was broken that needed fixing?) > block.c | 2 +- > in

[Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity()

2015-09-05 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 2 +- include/block/block.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 4f7fc0d..6d14f5b 100644 --- a/block.c +++ b/block.c @@ -3591,7 +3591,7 @@ uint32_t bdrv_get_default_b