Re: [Qemu-devel] [PATCH 01/14] tests: more thorough tests of ds1338

2018-07-17 Thread Peter Maydell
On 5 July 2018 at 19:19, Michael Davidsaver wrote: > Test current time and set+get round trip. > > Separate current time test from set/get tests > to avoid test needing to impose order, or to > have a magic handshaketo reset RTC to current time. > > Signed-off-by: Michael Davidsaver > --- > test

[Qemu-devel] [PATCH 01/14] tests: more thorough tests of ds1338

2018-07-05 Thread Michael Davidsaver
Test current time and set+get round trip. Separate current time test from set/get tests to avoid test needing to impose order, or to have a magic handshaketo reset RTC to current time. Signed-off-by: Michael Davidsaver --- tests/Makefile.include | 4 ++ tests/ds-rtc-common.h | 67

Re: [Qemu-devel] [PATCH 01/14] tests: more thorough tests of ds1338

2018-03-26 Thread Michael Davidsaver
On 03/26/2018 02:18 AM, Paolo Bonzini wrote: > On 24/03/2018 20:24, Michael Davidsaver wrote: >> Test current time and set+get round trip. >> Separate current time test from set/get >> tests to avoid test order issues. > > What are these issues? You can start a different QEMU for each test. Quit

Re: [Qemu-devel] [PATCH 01/14] tests: more thorough tests of ds1338

2018-03-26 Thread Paolo Bonzini
On 24/03/2018 20:24, Michael Davidsaver wrote: > Test current time and set+get round trip. > Separate current time test from set/get > tests to avoid test order issues. What are these issues? You can start a different QEMU for each test. Paolo > Signed-off-by: Michael Davidsaver

[Qemu-devel] [PATCH 01/14] tests: more thorough tests of ds1338

2018-03-24 Thread Michael Davidsaver
Test current time and set+get round trip. Separate current time test from set/get tests to avoid test order issues. Signed-off-by: Michael Davidsaver --- tests/Makefile.include | 4 ++ tests/ds-rtc-common.h | 67 + tests/ds-rtc-current-test.c | 59 +