Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-06 Thread Kevin Wolf
Am 03.12.2010 22:23, schrieb ronnie sahlberg: > Thankyou. > > On Sat, Dec 4, 2010 at 7:32 AM, Stefan Hajnoczi wrote: >> >> You want the library to be GPL, not LGPL? > > I have changed it to LGPLv3 for next submission. Please use "LGPL 2.1 or later". IIRC, qemu has some parts that are GPL 2 only

Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-03 Thread ronnie sahlberg
Thankyou. On Sat, Dec 4, 2010 at 7:32 AM, Stefan Hajnoczi wrote: > > You want the library to be GPL, not LGPL? I have changed it to LGPLv3 for next submission. >> +       /* use a "random" isid */ >> +       srandom(getpid() ^ time(NULL)); > > The random number generator has global state and th

Re: [Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-03 Thread Stefan Hajnoczi
On Fri, Dec 3, 2010 at 11:09 AM, wrote: > @@ -0,0 +1,215 @@ > +/* > +   Copyright (C) 2010 by Ronnie Sahlberg > + > +   This program is free software; you can redistribute it and/or modify > +   it under the terms of the GNU General Public License as published by > +   the Free Software Foundati

[Qemu-devel] [PATCH 01/14] ./block/iscsi/init.c

2010-12-03 Thread ronniesahlberg
From: Ronnie Sahlberg iscsi client library : init.c This file contains functions to create a iscsi context, destroy a context, error reporting api, as well as basic functions to manipulate properties of an iscsi context. ... ./block/iscsi/ contains a copy of a general purpose iscsi client lib