Re: [Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-13 Thread Fam Zheng
On Tue, 02/09 18:16, John Snow wrote: > Sure, but the failure here is not particularly obvious, because it makes > it seem as if docker has failed instead of a sudo privilege situation. Of course you're right, I'll improve the error message. Thanks! Fam

Re: [Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-09 Thread John Snow
On 02/08/2016 09:01 PM, Fam Zheng wrote: > On Mon, 02/08 16:49, John Snow wrote: >>> +def _guess_command(self): >>> +for c in [["docker"], ["sudo", "-n", "docker"]]: >> >> If the sudo version fails (Say, because a password prompt shows up) we >> get the unhelpful error "Cannot find wo

Re: [Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-08 Thread Fam Zheng
On Mon, 02/08 16:49, John Snow wrote: > > +def _guess_command(self): > > +for c in [["docker"], ["sudo", "-n", "docker"]]: > > If the sudo version fails (Say, because a password prompt shows up) we > get the unhelpful error "Cannot find working docker command." If you have previously

Re: [Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-08 Thread John Snow
On 02/05/2016 04:24 AM, Fam Zheng wrote: > docker_run: A wrapper for "docker run" (or "sudo -n docker run" if > necessary), which takes care of killing and removing the running > container at SIGINT. > > docker_clean: A tool to tear down all the containers including inactive > ones that are star

[Qemu-devel] [PATCH 01/12] tests: Add utilities for docker testing

2016-02-05 Thread Fam Zheng
docker_run: A wrapper for "docker run" (or "sudo -n docker run" if necessary), which takes care of killing and removing the running container at SIGINT. docker_clean: A tool to tear down all the containers including inactive ones that are started by docker_run. docker_build: A tool to compare an