Re: [Qemu-devel] [PATCH 01/12] target-i386: Avoid shifting left into sign bit

2014-03-10 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 07:10:37PM +, Peter Maydell wrote: > Add 'U' suffixes where necessary to avoid (1 << 31) which > shifts left into the sign bit, which is undefined behaviour. > > Signed-off-by: Peter Maydell While not required for correctness, I think it would be cleaner to change the

[Qemu-devel] [PATCH 01/12] target-i386: Avoid shifting left into sign bit

2014-03-10 Thread Peter Maydell
Add 'U' suffixes where necessary to avoid (1 << 31) which shifts left into the sign bit, which is undefined behaviour. Signed-off-by: Peter Maydell --- target-i386/cpu.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 0014ac