Re: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

2017-01-04 Thread Eric Blake
On 01/04/2017 03:20 PM, Marc-André Lureau wrote: > Hi > > On Mon, Jan 2, 2017 at 11:27 AM Paolo Bonzini wrote: > >> >> >> On 12/12/2016 23:42, Marc-André Lureau wrote: >>> >>> Note: this series has been tested with Linux and cross-building with >>> mingw. It mostly breaks on other platforms, >>

Re: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

2017-01-04 Thread Marc-André Lureau
Hi On Mon, Jan 2, 2017 at 11:27 AM Paolo Bonzini wrote: > > > On 12/12/2016 23:42, Marc-André Lureau wrote: > > > > Note: this series has been tested with Linux and cross-building with > > mingw. It mostly breaks on other platforms, > > What breaks exactly? > > Not much that I know. I was afraid

Re: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

2017-01-02 Thread Paolo Bonzini
On 12/12/2016 23:42, Marc-André Lureau wrote: > > Note: this series has been tested with Linux and cross-building with > mingw. It mostly breaks on other platforms, What breaks exactly? Paolo > help welcome for > testing. I'd also like to write more chardev backend tests to ensure > no regres

Re: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

2016-12-12 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify Type: series Message-id: 20161212224325.20790-1-marcandre.lur...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH 00/54] WIP: chardev: qom-ify

2016-12-12 Thread Marc-André Lureau
Hi, This is a followup of the series "char: fixes and improvements", where I started to refactor a bit the code to allow qom-ification. Paolo quickly reviewed some of those patches already. qemu-char.c is quite a large file (~130k, 5000 loc) with may chardev and a lot of #ifdef. It doesn't use qe