Re: [Qemu-devel] [PATCH 00/17] Fix usage of error_append_hint()

2019-09-17 Thread Daniel P . Berrangé
On Tue, Sep 17, 2019 at 01:45:29PM +0200, Greg Kurz wrote: > On Tue, 17 Sep 2019 13:00:37 +0200 > Philippe Mathieu-Daudé wrote: > > > For some reason your email client escaped incorrectly Daniel's email: > > > > "Daniel P. Berrangé\" > > > > The client is stgit's "stg mail" command, and ind

Re: [Qemu-devel] [PATCH 00/17] Fix usage of error_append_hint()

2019-09-17 Thread Greg Kurz
On Tue, 17 Sep 2019 13:00:37 +0200 Philippe Mathieu-Daudé wrote: > For some reason your email client escaped incorrectly Daniel's email: > > "Daniel P. Berrangé\" > The client is stgit's "stg mail" command, and indeed it generates this: "Daniel P. =?utf-8?q?Berrang=C3=A9=22?=

Re: [Qemu-devel] [PATCH 00/17] Fix usage of error_append_hint()

2019-09-17 Thread Philippe Mathieu-Daudé
For some reason your email client escaped incorrectly Daniel's email: "Daniel P. Berrangé\" Which makes my email client very unhappy (Thunderbird): There are non-ASCII characters in the local part of the recipient address "Daniel P. Berrangé , qemu-bl...@nongnu.org, qemu-...@nongnu.org, qemu-

[Qemu-devel] [PATCH 00/17] Fix usage of error_append_hint()

2019-09-17 Thread Greg Kurz
A recent post unveiled a potential problem when passing errp to error_append_hint(): https://patchwork.ozlabs.org/patch/1162171/ The issue is that error_append_hint() may end up not being called at all if errp is equal to &error_fatal or &error_abort. It turns out that the only way to ensure erro