Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-09 Thread Jes Sorensen
On 06/09/10 09:07, Markus Armbruster wrote: > Jes Sorensen writes: >> On 06/04/10 13:54, Markus Armbruster wrote: >> If there is strong feeling we should do it this way instead, I can >> change the code to do it this way instead. I am not married to the >> current approach, I just find it the less

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-09 Thread Markus Armbruster
Jes Sorensen writes: > On 06/04/10 13:54, Markus Armbruster wrote: >> Jes Sorensen writes: >> >>> On 06/04/10 10:21, Markus Armbruster wrote: I like moving stuff out of vl.c in general. Your moves of entire functions look like a win to me. I have doubts about spreading the opti

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Jes Sorensen
On 06/04/10 13:54, Markus Armbruster wrote: > Jes Sorensen writes: > >> On 06/04/10 10:21, Markus Armbruster wrote: >>> I like moving stuff out of vl.c in general. Your moves of entire >>> functions look like a win to me. I have doubts about spreading the >>> option switch over three files, tho

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Markus Armbruster
Jes Sorensen writes: > On 06/04/10 10:21, Markus Armbruster wrote: >> jes.soren...@redhat.com writes: >>> I have tried to be as careful as I can to not break non Linux support, >>> but as I only have a Linux build environment handy, I would appreciate >>> it if people with other OSes could check

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Jes Sorensen
On 06/04/10 10:21, Markus Armbruster wrote: > jes.soren...@redhat.com writes: >> I have tried to be as careful as I can to not break non Linux support, >> but as I only have a Linux build environment handy, I would appreciate >> it if people with other OSes could check that I didn't break anything

Re: [Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-04 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > Hi, > > I have been working on a set of patches to clean up the vl.c code, by > separating out OS specific code into OS specific files. Basically it > introduces two header files: qemu-os-win32.h and qemu-os-posix.h as > well as os-win32.c

[Qemu-devel] [PATCH 00/16] clean up vl.c code

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen Hi, I have been working on a set of patches to clean up the vl.c code, by separating out OS specific code into OS specific files. Basically it introduces two header files: qemu-os-win32.h and qemu-os-posix.h as well as os-win32.c and os-posix.c. I have tried to be as careful