Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

2017-06-26 Thread Alex Bennée
Richard Henderson writes: > On 06/26/2017 09:49 AM, Alex Bennée wrote: >> Hmm it compile tested fine on mine but: >> >> qemu-system-sparc: /home/alex/lsrc/qemu/qemu.git/tcg/tcg.h:725: temp_arg: >> Assertion `n < tcg_ctx.nb_temps' failed. > > Bah. I fixed this, and then lost it while rebasing.

Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

2017-06-26 Thread Richard Henderson
On 06/26/2017 09:49 AM, Alex Bennée wrote: Hmm it compile tested fine on mine but: qemu-system-sparc: /home/alex/lsrc/qemu/qemu.git/tcg/tcg.h:725: temp_arg: Assertion `n < tcg_ctx.nb_temps' failed. Bah. I fixed this, and then lost it while rebasing. It's an uninitialized structure member.

Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

2017-06-26 Thread Alex Bennée
Richard Henderson writes: > There are two conceptually unrelated cleanups in here, though > the second touches many of the same lines as the first, so > separating the two would be ugly. > > The first is to split gen_opparam_buf and move the pieces into > TCGOp. This has two effects: the operan

Re: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

2017-06-20 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end Type: series Message-id: 20170621024831.26019-1-...@twiddle.net === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [PATCH 00/16] Cleanups within TCG middle-end

2017-06-20 Thread Richard Henderson
There are two conceptually unrelated cleanups in here, though the second touches many of the same lines as the first, so separating the two would be ugly. The first is to split gen_opparam_buf and move the pieces into TCGOp. This has two effects: the operands for an op is in the same cacheline as