Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-06-02 Thread Eric Blake
On 06/02/2015 05:51 AM, Markus Armbruster wrote: The most confusing part about this is that you have &error_abort almost everywhere, but the function doesn't actually abort on error, but rather returns a negative error code and leaves errp alone. >>> >>> True. The function contract

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-06-02 Thread Markus Armbruster
Eric Blake writes: > On 05/29/2015 05:22 AM, Markus Armbruster wrote: >> Kevin Wolf writes: >> >>> Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben: Touches vl.c, which gives me pretext to ask Paolo: would you be willing to take this through your tree? Or should I take it thr

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-05-29 Thread Eric Blake
On 05/29/2015 05:22 AM, Markus Armbruster wrote: > Kevin Wolf writes: > >> Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben: >>> Touches vl.c, which gives me pretext to ask Paolo: would you be >>> willing to take this through your tree? Or should I take it through >>> mine? >> >> After t

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-05-29 Thread Kevin Wolf
Am 29.05.2015 um 13:22 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben: > >> Touches vl.c, which gives me pretext to ask Paolo: would you be > >> willing to take this through your tree? Or should I take it through > >> mine?

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-05-29 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben: >> Touches vl.c, which gives me pretext to ask Paolo: would you be >> willing to take this through your tree? Or should I take it through >> mine? > > After this series we have an ugly half-converted state where > qem

Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-05-29 Thread Kevin Wolf
Am 28.05.2015 um 14:21 hat Markus Armbruster geschrieben: > Touches vl.c, which gives me pretext to ask Paolo: would you be > willing to take this through your tree? Or should I take it through > mine? After this series we have an ugly half-converted state where qemu_opts_foreach() has both a ret

[Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements

2015-05-28 Thread Markus Armbruster
Touches vl.c, which gives me pretext to ask Paolo: would you be willing to take this through your tree? Or should I take it through mine? Markus Armbruster (9): vl: Report failure to sandbox at most once vl: Print -device help at most once vl: Fail right after first bad -object QemuOpts: