Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-03 Thread Anthony Liguori
On 02/01/2010 01:50 PM, Luiz Capitulino wrote: Capability selection could be done as an object where the name/value pairs are capability/argument. If you need multiple arguments for a capability, make the capability's value an object. That's exactly what seems complicated to me, because

Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-02 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 02 Feb 2010 09:03:32 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Mon, 01 Feb 2010 20:37:41 +0100 >> > Markus Armbruster wrote: >> > >> >> Luiz Capitulino writes: >> >> >> >> > On Mon, 01 Feb 2010 18:08:27 +0100 >> >> > Markus Ar

Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-02 Thread Luiz Capitulino
On Tue, 02 Feb 2010 09:03:32 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Mon, 01 Feb 2010 20:37:41 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > On Mon, 01 Feb 2010 18:08:27 +0100 > >> > Markus Armbruster wrote: > [...] > >> >> I don't

Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-02 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 01 Feb 2010 20:37:41 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > On Mon, 01 Feb 2010 18:08:27 +0100 >> > Markus Armbruster wrote: [...] >> >> I don't doubt your design does the job. I just think it's overly >> >> general. I had som

Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-01 Thread Luiz Capitulino
On Mon, 01 Feb 2010 20:37:41 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Mon, 01 Feb 2010 18:08:27 +0100 > > Markus Armbruster wrote: > > > >> Luiz Capitulino writes: > >> > >> > Feature negotiation allows clients to enable new QMP capabilities they > >> > support and

Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-01 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 01 Feb 2010 18:08:27 +0100 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > Feature negotiation allows clients to enable new QMP capabilities they >> > support and thus allows QMP to envolve in a compatible way. >> > >> > A capability is a new

Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-01 Thread Luiz Capitulino
On Mon, 01 Feb 2010 18:08:27 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Feature negotiation allows clients to enable new QMP capabilities they > > support and thus allows QMP to envolve in a compatible way. > > > > A capability is a new QMP feature and/or protocol change w

Re: [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-02-01 Thread Markus Armbruster
Luiz Capitulino writes: > Feature negotiation allows clients to enable new QMP capabilities they > support and thus allows QMP to envolve in a compatible way. > > A capability is a new QMP feature and/or protocol change which is not part of > the core protocol as defined in the QMP spec. Well,

[Qemu-devel] [PATCH 0/8]: QMP feature negotiation support

2010-01-28 Thread Luiz Capitulino
Feature negotiation allows clients to enable new QMP capabilities they support and thus allows QMP to envolve in a compatible way. A capability is a new QMP feature and/or protocol change which is not part of the core protocol as defined in the QMP spec. Feature negotiation is implemented by,