Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-31 Thread Kevin Wolf
Am 30.08.2011 20:29, schrieb Alexander Graf: > > On 30.08.2011, at 19:25, Stefan Weil wrote: > >> Am 30.08.2011 09:44, schrieb Kevin Wolf: >>> Am 29.08.2011 21:55, schrieb Stefan Weil: Am 29.08.2011 10:34, schrieb TeLeMan: > On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: >> Am 28

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-30 Thread Blue Swirl
On Tue, Aug 30, 2011 at 6:29 PM, Alexander Graf wrote: > > On 30.08.2011, at 19:25, Stefan Weil wrote: > >> Am 30.08.2011 09:44, schrieb Kevin Wolf: >>> Am 29.08.2011 21:55, schrieb Stefan Weil: Am 29.08.2011 10:34, schrieb TeLeMan: > On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: >>>

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-30 Thread Alexander Graf
On 30.08.2011, at 19:25, Stefan Weil wrote: > Am 30.08.2011 09:44, schrieb Kevin Wolf: >> Am 29.08.2011 21:55, schrieb Stefan Weil: >>> Am 29.08.2011 10:34, schrieb TeLeMan: On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: > Am 28.08.2011 23:43, schrieb Blue Swirl: >> >> On Su

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-30 Thread Stefan Weil
Am 30.08.2011 09:44, schrieb Kevin Wolf: Am 29.08.2011 21:55, schrieb Stefan Weil: Am 29.08.2011 10:34, schrieb TeLeMan: On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: Am 28.08.2011 23:43, schrieb Blue Swirl: On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: These patches fix the pa

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-30 Thread Kevin Wolf
Am 29.08.2011 21:55, schrieb Stefan Weil: > Am 29.08.2011 10:34, schrieb TeLeMan: >> On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: >>> Am 28.08.2011 23:43, schrieb Blue Swirl: On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: > > These patches fix the packing of stru

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-29 Thread Stefan Weil
Am 29.08.2011 10:34, schrieb TeLeMan: On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: Am 28.08.2011 23:43, schrieb Blue Swirl: On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: These patches fix the packing of structures which were affected by the new compiler attribute -mms-bitfields

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-29 Thread Alexander Graf
Am 29.08.2011 um 10:34 schrieb TeLeMan : > On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: >> Am 28.08.2011 23:43, schrieb Blue Swirl: >>> >>> On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: These patches fix the packing of structures which were affected by the new com

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-29 Thread TeLeMan
On Mon, Aug 29, 2011 at 13:01, Stefan Weil wrote: > Am 28.08.2011 23:43, schrieb Blue Swirl: >> >> On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: >>> >>> These patches fix the packing of structures which were affected by >>> the new compiler attribute -mms-bitfields (which is needed for glib

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-29 Thread Gerd Hoffmann
Hi, If a structure is only used internally by QEMU (not used in network, disk or guest interfaces), changes in padding don't matter. [PATCH 5/7] usb: Fix packing for w32: needs packing (usb interface) Patch looks good (and is needed as the structs are part of the guest interface). chee

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-28 Thread Stefan Weil
Am 28.08.2011 23:43, schrieb Blue Swirl: On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: These patches fix the packing of structures which were affected by the new compiler attribute -mms-bitfields (which is needed for glib-2.0). I compiled qemu.exe with and without -mms-bitfields and comp

Re: [Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-28 Thread Blue Swirl
On Sun, Aug 28, 2011 at 8:43 PM, Stefan Weil wrote: > These patches fix the packing of structures which were affected by > the new compiler attribute -mms-bitfields (which is needed for glib-2.0). > > I compiled qemu.exe with and without -mms-bitfields and compared > the resulting struct alignment

[Qemu-devel] [PATCH 0/7] Fix packing for MinGW with -mms-bitfields

2011-08-28 Thread Stefan Weil
These patches fix the packing of structures which were affected by the new compiler attribute -mms-bitfields (which is needed for glib-2.0). I compiled qemu.exe with and without -mms-bitfields and compared the resulting struct alignment using pahole and codiff. The patches are split for different