Re: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-13 Thread Pavel Pisa
Hello Konrad, thanks for review. On Friday 12 of January 2018 11:43:18 KONRAD Frederic wrote: > You should add that to the title as well: > > git format-patch ... --subject-prefix="PATCH V3" ... > > to avoid any confusion. OK, I add V4. > You need to run the ./scripts/checkpatch.pl on your patc

Re: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-12 Thread KONRAD Frederic
Hi Pavel, On 01/06/2018 09:47 PM, p...@cmp.felk.cvut.cz wrote: From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. Patches version 3: Support to connect to host SocketCAN interface has been separated from the core bus implementation. Only simple statically ini

Re: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-11 Thread Oleksij Rempel
Hi, thank you for your work! we integrated your patches in our OSALES BSP [1] and did some basic tests: - communication between host and guest - communication between real CAN/J1939 device over the host to guest. J1939(real device) -> candleLight v1.1 -> host (kernel v4.13) -> QEMU (with your CA

Re: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1515260163.git.p...@cmp.felk.cvut.cz Subject: [Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far) === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

[Qemu-devel] [PATCH 0/7] CAN bus support for QEMU (SJA1000 PCI so far)

2018-01-06 Thread pisa
From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. Patches version 3: Support to connect to host SocketCAN interface has been separated from the core bus implementation. Only simple statically initialize pointer to the connection function is used, no QOM concept