Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Andreas Färber
Am 09.05.2013 10:09, schrieb Michael Tokarev: > 22.02.2013 22:09, Peter Maydell wrote: >> cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC > > This needed a "back merge" of env+cpu states back to cpu. > Maybe we should somehow revisit the whole concept of the > two, because it's sorta

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Michael Tokarev
09.05.2013 13:01, Peter Maydell wrote: > On 9 May 2013 09:09, Michael Tokarev wrote: >> Now, the resulting thing compiles (ha!), but I'm not >> really sure how to test it. I ran a few random apps >> using qemu-i386 and qemu-arm, it appears to work. > > You need to test TCG system emulation too,

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Peter Maydell
On 9 May 2013 09:09, Michael Tokarev wrote: > Now, the resulting thing compiles (ha!), but I'm not > really sure how to test it. I ran a few random apps > using qemu-i386 and qemu-arm, it appears to work. You need to test TCG system emulation too, and in particular something with multiple guest

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-05-09 Thread Michael Tokarev
[Rehashing a relatively old thread. It is available, in particular, at http://thread.gmane.org/gmane.comp.emulators.qemu/196629] 22.02.2013 22:09, Peter Maydell wrote: > This patch series gets rid of cpu_unlink_tb(), which is irredeemably > racy, since it modifies the TB graph with no locking fr

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-03-03 Thread Blue Swirl
Thanks, applied all. On Fri, Feb 22, 2013 at 6:09 PM, Peter Maydell wrote: > This patch series gets rid of cpu_unlink_tb(), which is irredeemably > racy, since it modifies the TB graph with no locking from other > threads, signal handlers, etc etc. (The signal handler case is > why you can't just

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-03-03 Thread Peter Maydell
Ping! thanks -- PMM On 23 February 2013 02:09, Peter Maydell wrote: > This patch series gets rid of cpu_unlink_tb(), which is irredeemably > racy, since it modifies the TB graph with no locking from other > threads, signal handlers, etc etc. (The signal handler case is > why you can't just fix t

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-02-22 Thread Richard Henderson
On 02/22/2013 10:09 AM, Peter Maydell wrote: > Andreas Färber (1): > cpu: Introduce ENV_OFFSET macros > > Peter Maydell (5): > tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses > cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC > Handle CPU interrupts by in

[Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-02-22 Thread Peter Maydell
This patch series gets rid of cpu_unlink_tb(), which is irredeemably racy, since it modifies the TB graph with no locking from other threads, signal handlers, etc etc. (The signal handler case is why you can't just fix this with more locks.) Instead we take the much simpler approach of setting a fl