Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-21 Thread Luiz Capitulino
On Thu, 20 May 2010 10:35:52 -0300 Luiz Capitulino wrote: > > > 2. QMP doesn't check the return of json_message_parser_feed() > > > > > > Which means we don't handle JSON syntax errors. While the fix might > > > seem > > > trivial (ie. just return an error!), I'm not sure what's the best

Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Avi Kivity
On 05/20/2010 12:43 AM, Anthony Liguori wrote: The JSON specification explicitly says: "A JSON parser transforms a JSON text into another representation. A JSON parser MUST accept all texts that conform to the JSON grammar. A JSON parser MAY accept non-JSON forms or extensions." IOW, we're

Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-20 Thread Luiz Capitulino
On Wed, 19 May 2010 16:43:08 -0500 Anthony Liguori wrote: > On 05/19/2010 04:15 PM, Luiz Capitulino wrote: > > Hi Anthony, > > > > While investigating a QMP bug reported by a user, I've found a few issues > > in our parser/lexer. > > > > The patches in this series fix the problems I was abl

Re: [Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-19 Thread Anthony Liguori
On 05/19/2010 04:15 PM, Luiz Capitulino wrote: Hi Anthony, While investigating a QMP bug reported by a user, I've found a few issues in our parser/lexer. The patches in this series fix the problems I was able to solve, but we still have the following issues: 1. Our 'private extension' is

[Qemu-devel] [PATCH 0/6]: QMP: Fix issues in parser/lexer

2010-05-19 Thread Luiz Capitulino
Hi Anthony, While investigating a QMP bug reported by a user, I've found a few issues in our parser/lexer. The patches in this series fix the problems I was able to solve, but we still have the following issues: 1. Our 'private extension' is open to the public Eg. The following input issu