Re: [Qemu-devel] [PATCH 0/5] multiboot: Fix buffer overflow on invalid kernels

2018-03-14 Thread Jack Schwartz
Hi Kevin. I see an issue with the commit message of patch 1; please see my reply to that patch for details.  I fully understand patches 1,2,3, patch 4 except for some of the Makefile black magic, and patch 5 looks reasonable to me. So, for patches 2,3,4,5:     Reviewed-by: Jack Schwartz   

[Qemu-devel] [PATCH 0/5] multiboot: Fix buffer overflow on invalid kernels

2018-03-14 Thread Kevin Wolf
Patch 1 fixes another Multiboot kernel validation bug that could cause QEMU to load the kernel image file into a too small buffer. Patch 2 adds another check to harden the code. The rest of the series adds Multiboot test cases for kernels using the a.out kludge, which is where the recent bugs were