Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Jeff Cody
On Fri, Aug 15, 2014 at 08:22:12AM -0600, Eric Blake wrote: > On 08/15/2014 08:10 AM, Jeff Cody wrote: > > On Fri, Aug 15, 2014 at 08:00:19AM -0600, Eric Blake wrote: > >> On 08/15/2014 07:37 AM, Kevin Wolf wrote: > >> > >>> We can choose Markus's suggestion of using the file name to guess the > >>

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Kevin Wolf
Am 15.08.2014 um 16:00 hat Eric Blake geschrieben: > On 08/15/2014 07:37 AM, Kevin Wolf wrote: > > > We can choose Markus's suggestion of using the file name to guess the > > format. I don't really like it much, but it seems like a fair compromise > > that doesn't hurt usability as much. > > In o

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Eric Blake
On 08/15/2014 08:10 AM, Jeff Cody wrote: > On Fri, Aug 15, 2014 at 08:00:19AM -0600, Eric Blake wrote: >> On 08/15/2014 07:37 AM, Kevin Wolf wrote: >> >>> We can choose Markus's suggestion of using the file name to guess the >>> format. I don't really like it much, but it seems like a fair compromi

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Jeff Cody
On Fri, Aug 15, 2014 at 08:00:19AM -0600, Eric Blake wrote: > On 08/15/2014 07:37 AM, Kevin Wolf wrote: > > > We can choose Markus's suggestion of using the file name to guess the > > format. I don't really like it much, but it seems like a fair compromise > > that doesn't hurt usability as much.

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Eric Blake
On 08/15/2014 07:37 AM, Kevin Wolf wrote: > We can choose Markus's suggestion of using the file name to guess the > format. I don't really like it much, but it seems like a fair compromise > that doesn't hurt usability as much. In other words, if a user gives a file a "known suffix", then it is t

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Jeff Cody
On Fri, Aug 15, 2014 at 03:37:56PM +0200, Kevin Wolf wrote: > Am 15.08.2014 um 14:14 hat Jeff Cody geschrieben: > > On Fri, Aug 15, 2014 at 12:55:19PM +0200, Kevin Wolf wrote: > > > Am 14.08.2014 um 16:57 hat Jeff Cody geschrieben: > > > > On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wr

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Kevin Wolf
Am 15.08.2014 um 14:14 hat Jeff Cody geschrieben: > On Fri, Aug 15, 2014 at 12:55:19PM +0200, Kevin Wolf wrote: > > Am 14.08.2014 um 16:57 hat Jeff Cody geschrieben: > > > On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wrote: > > > > On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Jeff Cody
On Fri, Aug 15, 2014 at 07:13:07AM -0600, Eric Blake wrote: > On 08/15/2014 06:28 AM, Jeff Cody wrote: > > > I worry that will subtly alter current behavior in bad ways. For > > instance, take this image chain: > > > > qemu-img create -f qcow2 foo.img 1G > > qemu-img create -f qcow2 -b f

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Eric Blake
On 08/15/2014 06:14 AM, Jeff Cody wrote: > > And of course, convenience options like -hda spit out the deprecation > warning - which I think is probably a good thing. Here is what I made > it say: > > fprintf(stderr, "Format autodetection is deprecated and may be " > "remove

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Eric Blake
On 08/15/2014 06:28 AM, Jeff Cody wrote: > I worry that will subtly alter current behavior in bad ways. For > instance, take this image chain: > > qemu-img create -f qcow2 foo.img 1G > qemu-img create -f qcow2 -b foo.img bar.img 1G > > qemu-kvm -drive file=bar.img,format=qcow2 > >

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Markus Armbruster
Jeff Cody writes: > On Fri, Aug 15, 2014 at 01:21:19PM +0200, Markus Armbruster wrote: >> Kevin Wolf writes: >> >> > Am 14.08.2014 um 16:57 hat Jeff Cody geschrieben: >> >> On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wrote: >> >> > On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Jeff Cody
On Fri, Aug 15, 2014 at 01:21:19PM +0200, Markus Armbruster wrote: > Kevin Wolf writes: > > > Am 14.08.2014 um 16:57 hat Jeff Cody geschrieben: > >> On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wrote: > >> > On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote: > >> > > On Tue, Aug

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Jeff Cody
On Fri, Aug 15, 2014 at 12:55:19PM +0200, Kevin Wolf wrote: > Am 14.08.2014 um 16:57 hat Jeff Cody geschrieben: > > On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wrote: > > > On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote: > > > > On Tue, Aug 12, 2014 at 02:20:34PM +0100, Stefan

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.08.2014 um 16:57 hat Jeff Cody geschrieben: >> On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wrote: >> > On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote: >> > > On Tue, Aug 12, 2014 at 02:20:34PM +0100, Stefan Hajnoczi wrote: >> > > > On Fri, Aug 01,

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-15 Thread Kevin Wolf
Am 14.08.2014 um 16:57 hat Jeff Cody geschrieben: > On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wrote: > > On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote: > > > On Tue, Aug 12, 2014 at 02:20:34PM +0100, Stefan Hajnoczi wrote: > > > > On Fri, Aug 01, 2014 at 03:39:58PM +0200, L

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-14 Thread Jeff Cody
On Thu, Aug 14, 2014 at 10:42:27AM -0400, Levente Kurusa wrote: > On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote: > > On Tue, Aug 12, 2014 at 02:20:34PM +0100, Stefan Hajnoczi wrote: > > > On Fri, Aug 01, 2014 at 03:39:58PM +0200, Levente Kurusa wrote: > > > > Fixed size VPC images do not

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-14 Thread Levente Kurusa
On Tuesday, 12 August, 2014 3:35:42 PM, Jeff Cody wrote: > On Tue, Aug 12, 2014 at 02:20:34PM +0100, Stefan Hajnoczi wrote: > > On Fri, Aug 01, 2014 at 03:39:58PM +0200, Levente Kurusa wrote: > > > Fixed size VPC images do not have a footer, hence the current probe > > > function will fail and QEMU

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-12 Thread Jeff Cody
On Tue, Aug 12, 2014 at 02:20:34PM +0100, Stefan Hajnoczi wrote: > On Fri, Aug 01, 2014 at 03:39:58PM +0200, Levente Kurusa wrote: > > Fixed size VPC images do not have a footer, hence the current probe > > function will fail and QEMU will fall back to the raw_bsd driver, which is > > not the corre

Re: [Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-12 Thread Stefan Hajnoczi
On Fri, Aug 01, 2014 at 03:39:58PM +0200, Levente Kurusa wrote: > Fixed size VPC images do not have a footer, hence the current probe > function will fail and QEMU will fall back to the raw_bsd driver, which is > not the correct behaviour. The specification of the format says that fixed > size imag

[Qemu-devel] [PATCH 0/3] vpc: support probing of fixed size images

2014-08-01 Thread Levente Kurusa
Fixed size VPC images do not have a footer, hence the current probe function will fail and QEMU will fall back to the raw_bsd driver, which is not the correct behaviour. The specification of the format says that fixed size images have a footer as the last 512 bytes of the file. The footer is exactl