Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Michael S. Tsirkin
On Fri, Nov 05, 2010 at 05:01:49PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Nov 05, 2010 at 02:27:49PM +0100, Markus Armbruster wrote: > >> I'd be fine with any of these: > >> > >> 1. A new command "device_disconnet ID" (or similar name) to disconnect > >>

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 12:39:01PM -0600, Ryan Harper wrote: > * Michael S. Tsirkin [2010-11-08 10:57]: > > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > > * Markus Armbruster [2010-11-08 06:04]: > > > > "Michael S. Tsirkin" writes: > > > > > > > > > On Mon, Nov 08, 2010 at 1

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
* Daniel P. Berrange [2010-11-08 11:05]: > On Mon, Nov 08, 2010 at 06:56:02PM +0200, Michael S. Tsirkin wrote: > > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > > * Markus Armbruster [2010-11-08 06:04]: > > > > "Michael S. Tsirkin" writes: > > > > >> Here's how the various obj

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-08 10:57]: > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > * Markus Armbruster [2010-11-08 06:04]: > > > "Michael S. Tsirkin" writes: > > > > > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > > > >> Ryan Harper writes: >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 06:56:02PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > > * Markus Armbruster [2010-11-08 06:04]: > > > "Michael S. Tsirkin" writes: > > > >> Here's how the various objects are connected to each other: > > > >> > > > >>

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 08:02:50AM -0600, Ryan Harper wrote: > * Markus Armbruster [2010-11-08 06:04]: > > "Michael S. Tsirkin" writes: > > > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > > >> Ryan Harper writes: > > >> > > >> > * Markus Armbruster [2010-11-06 04:19

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 01:03:18PM +0100, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > >> Ryan Harper writes: > >> > >> > * Markus Armbruster [2010-11-06 04:19]: > >> >> Ryan Harper writes: > >> >> > >> >>

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Ryan Harper
* Markus Armbruster [2010-11-08 06:04]: > "Michael S. Tsirkin" writes: > > > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > >> Ryan Harper writes: > >> > >> > * Markus Armbruster [2010-11-06 04:19]: > >> >> Ryan Harper writes: > >> >> > >> >> > * Markus Armbruster [20

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: >> Ryan Harper writes: >> >> > * Markus Armbruster [2010-11-06 04:19]: >> >> Ryan Harper writes: >> >> >> >> > * Markus Armbruster [2010-11-05 11:11]: >> >> >> Ryan Harper writes: >> >> >> >>

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Michael S. Tsirkin
On Mon, Nov 08, 2010 at 11:32:01AM +0100, Markus Armbruster wrote: > Ryan Harper writes: > > > * Markus Armbruster [2010-11-06 04:19]: > >> Ryan Harper writes: > >> > >> > * Markus Armbruster [2010-11-05 11:11]: > >> >> Ryan Harper writes: > >> >> > >> >> > * Markus Armbruster [2010-11-05

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-08 Thread Markus Armbruster
Ryan Harper writes: > * Markus Armbruster [2010-11-06 04:19]: >> Ryan Harper writes: >> >> > * Markus Armbruster [2010-11-05 11:11]: >> >> Ryan Harper writes: >> >> >> >> > * Markus Armbruster [2010-11-05 08:28]: >> >> >> I'd be fine with any of these: >> >> >> >> >> >> 1. A new command "

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-07 Thread Ryan Harper
* Markus Armbruster [2010-11-06 04:19]: > Ryan Harper writes: > > > * Markus Armbruster [2010-11-05 11:11]: > >> Ryan Harper writes: > >> > >> > * Markus Armbruster [2010-11-05 08:28]: > >> >> I'd be fine with any of these: > >> >> > >> >> 1. A new command "device_disconnet ID" (or similar

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-06 Thread Markus Armbruster
Ryan Harper writes: > * Markus Armbruster [2010-11-05 11:11]: >> Ryan Harper writes: >> >> > * Markus Armbruster [2010-11-05 08:28]: >> >> I'd be fine with any of these: >> >> >> >> 1. A new command "device_disconnet ID" (or similar name) to disconnect >> >>device ID from any host parts.

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-05 Thread Ryan Harper
* Markus Armbruster [2010-11-05 11:11]: > Ryan Harper writes: > > > * Markus Armbruster [2010-11-05 08:28]: > >> I'd be fine with any of these: > >> > >> 1. A new command "device_disconnet ID" (or similar name) to disconnect > >>device ID from any host parts. Nice touch: you don't have to

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-05 Thread Markus Armbruster
Ryan Harper writes: > * Markus Armbruster [2010-11-05 08:28]: >> I'd be fine with any of these: >> >> 1. A new command "device_disconnet ID" (or similar name) to disconnect >>device ID from any host parts. Nice touch: you don't have to know >>about the device's host part(s) to disconne

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-05 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Nov 05, 2010 at 02:27:49PM +0100, Markus Armbruster wrote: >> I'd be fine with any of these: >> >> 1. A new command "device_disconnet ID" (or similar name) to disconnect >>device ID from any host parts. Nice touch: you don't have to know >>about th

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-05 Thread Ryan Harper
* Markus Armbruster [2010-11-05 08:28]: > Ryan Harper writes: > > > * Michael S. Tsirkin [2010-11-03 16:46]: > >> On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: > >> > * Michael S. Tsirkin [2010-11-03 13:03]: > >> > > On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-05 Thread Michael S. Tsirkin
On Fri, Nov 05, 2010 at 02:27:49PM +0100, Markus Armbruster wrote: > Ryan Harper writes: > > > * Michael S. Tsirkin [2010-11-03 16:46]: > >> On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: > >> > * Michael S. Tsirkin [2010-11-03 13:03]: > >> > > On Wed, Nov 03, 2010 at 12:29:10PM -

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-05 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-05 09:18]: > On Fri, Nov 05, 2010 at 02:27:49PM +0100, Markus Armbruster wrote: > > Ryan Harper writes: > > > > > * Michael S. Tsirkin [2010-11-03 16:46]: > > >> On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: > > >> > * Michael S. Tsirkin [2010-11-03

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-05 Thread Markus Armbruster
Ryan Harper writes: > * Michael S. Tsirkin [2010-11-03 16:46]: >> On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: >> > * Michael S. Tsirkin [2010-11-03 13:03]: >> > > On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: >> > > > * Markus Armbruster [2010-11-03 11:42]: >> >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-04 Thread Michael S. Tsirkin
On Thu, Nov 04, 2010 at 11:45:51AM -0500, Ryan Harper wrote: > OK. With netdev_del and drive_unplug commands (not sure if we care to > change the names to be similar, maybe blockdev_del) in qemu, we can then > implement the following in libvirt: > > 1) detach-device invocation > 2) issue device_d

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-04 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-03 16:46]: > On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: > > * Michael S. Tsirkin [2010-11-03 13:03]: > > > On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: > > > > * Markus Armbruster [2010-11-03 11:42]: > > > > > Ryan Harper writes: >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-03 Thread Michael S. Tsirkin
On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: > * Michael S. Tsirkin [2010-11-03 13:03]: > > On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: > > > * Markus Armbruster [2010-11-03 11:42]: > > > > Ryan Harper writes: > > > > > > > > > * Michael S. Tsirkin [2010-11-03

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-03 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-03 13:03]: > On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: > > * Markus Armbruster [2010-11-03 11:42]: > > > Ryan Harper writes: > > > > > > > * Michael S. Tsirkin [2010-11-03 02:22]: > > > >> On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wr

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-03 Thread Michael S. Tsirkin
On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: > * Markus Armbruster [2010-11-03 11:42]: > > Ryan Harper writes: > > > > > * Michael S. Tsirkin [2010-11-03 02:22]: > > >> On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wrote: > > >> > * Michael S. Tsirkin [2010-11-02 14:18]

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-03 Thread Ryan Harper
* Markus Armbruster [2010-11-03 11:42]: > Ryan Harper writes: > > > * Michael S. Tsirkin [2010-11-03 02:22]: > >> On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wrote: > >> > * Michael S. Tsirkin [2010-11-02 14:18]: > >> > > On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-03 Thread Markus Armbruster
Ryan Harper writes: > * Michael S. Tsirkin [2010-11-03 02:22]: >> On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wrote: >> > * Michael S. Tsirkin [2010-11-02 14:18]: >> > > On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: >> > > > > > > > I like the idea of disconnect; if par

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-03 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-03 02:22]: > On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wrote: > > * Michael S. Tsirkin [2010-11-02 14:18]: > > > On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: > > > > > > > > I like the idea of disconnect; if part of the device_del method

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-03 Thread Michael S. Tsirkin
On Tue, Nov 02, 2010 at 03:23:38PM -0500, Ryan Harper wrote: > * Michael S. Tsirkin [2010-11-02 14:18]: > > On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: > > > > > > > I like the idea of disconnect; if part of the device_del method > > > > > > > was to > > > > > > > invoke a discon

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-02 14:18]: > On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: > > > > > > I like the idea of disconnect; if part of the device_del method was > > > > > > to > > > > > > invoke a disconnect method, we could implement that for block, net, > > > > > > etc;

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Michael S. Tsirkin
On Tue, Nov 02, 2010 at 02:01:08PM -0500, Ryan Harper wrote: > > > > > I like the idea of disconnect; if part of the device_del method was to > > > > > invoke a disconnect method, we could implement that for block, net, > > > > > etc; > > > > > > > > > > I'd think we'd want to send the notificati

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Ryan Harper
> > > > I like the idea of disconnect; if part of the device_del method was to > > > > invoke a disconnect method, we could implement that for block, net, etc; > > > > > > > > I'd think we'd want to send the notification, then disconnect. > > > > Struggling with whether it's worth having some reas

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Michael S. Tsirkin
Cc yamah...@valinux.co.jp, he is working on hotplug for pci express. On Tue, Nov 02, 2010 at 11:53:39AM -0500, Ryan Harper wrote: > * Michael S. Tsirkin [2010-11-02 10:56]: > > On Tue, Nov 02, 2010 at 09:22:01AM -0500, Ryan Harper wrote: > > > * Michael S. Tsirkin [2010-11-02 08:59]: > > > > On

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-02 10:56]: > On Tue, Nov 02, 2010 at 09:22:01AM -0500, Ryan Harper wrote: > > * Michael S. Tsirkin [2010-11-02 08:59]: > > > On Tue, Nov 02, 2010 at 08:46:22AM -0500, Ryan Harper wrote: > > > > * Markus Armbruster [2010-11-02 04:40]: > > > > > > > >> >> I'd like to

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Michael S. Tsirkin
On Tue, Nov 02, 2010 at 09:22:01AM -0500, Ryan Harper wrote: > * Michael S. Tsirkin [2010-11-02 08:59]: > > On Tue, Nov 02, 2010 at 08:46:22AM -0500, Ryan Harper wrote: > > > * Markus Armbruster [2010-11-02 04:40]: > > > > > >> >> I'd like to have some consistency among net, block and char devic

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Michael S. Tsirkin
On Tue, Nov 02, 2010 at 08:46:22AM -0500, Ryan Harper wrote: > * Markus Armbruster [2010-11-02 04:40]: > > Ryan Harper writes: > > > > > * Markus Armbruster [2010-10-29 11:11]: > > >> Ryan Harper writes: > > >> > > >> > * Markus Armbruster [2010-10-29 09:13]: > > >> >> [Note cc: Michael] > >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Markus Armbruster
Ryan Harper writes: > * Markus Armbruster [2010-10-29 11:11]: >> Ryan Harper writes: >> >> > * Markus Armbruster [2010-10-29 09:13]: >> >> [Note cc: Michael] >> >> >> >> Ryan Harper writes: >> >> >> >> >> >> If I understand your patch correctly, the difference between your >> >> drive_unp

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Ryan Harper
* Michael S. Tsirkin [2010-11-02 08:59]: > On Tue, Nov 02, 2010 at 08:46:22AM -0500, Ryan Harper wrote: > > * Markus Armbruster [2010-11-02 04:40]: > > > >> >> I'd like to have some consistency among net, block and char device > > > >> >> commands, i.e. a common set of operations that work the s

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Kevin Wolf
Am 02.11.2010 10:40, schrieb Markus Armbruster: > Ryan Harper writes: > >> * Markus Armbruster [2010-10-29 11:11]: >>> Ryan Harper writes: >>> >>> Regardless of the way we choose, we need to think very clearly on how >>> exactly device models should behave when their host part is missing or a >

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Ryan Harper
* Markus Armbruster [2010-11-02 04:40]: > Ryan Harper writes: > > > * Markus Armbruster [2010-10-29 11:11]: > >> Ryan Harper writes: > >> > >> > * Markus Armbruster [2010-10-29 09:13]: > >> >> [Note cc: Michael] > >> >> > >> >> Ryan Harper writes: > >> >> > >> >> > >> >> If I understand

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-02 Thread Michael S. Tsirkin
On Tue, Nov 02, 2010 at 10:40:32AM +0100, Markus Armbruster wrote: > C. FOO_unplug > >You got a patch for drive_unplug. > >Need netdev_unplug. > >By the way, I hate "unplug", because it suggests relation to hot >unplug. What about "disconnect"? > Any preferences? This implies

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-10-29 Thread Ryan Harper
* Markus Armbruster [2010-10-29 11:11]: > Ryan Harper writes: > > > * Markus Armbruster [2010-10-29 09:13]: > >> [Note cc: Michael] > >> > >> Ryan Harper writes: > >> > >> > >> If I understand your patch correctly, the difference between your > >> drive_unplug and my blockdev_del is as foll

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-10-29 Thread Markus Armbruster
Ryan Harper writes: > * Markus Armbruster [2010-10-29 09:13]: >> [Note cc: Michael] >> >> Ryan Harper writes: >> >> > This patch series decouples the detachment of a block device from the >> > removal >> > of the backing pci-device. Removal of a hotplugged pci device requires the >> > guest

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-10-29 Thread Ryan Harper
* Markus Armbruster [2010-10-29 09:13]: > [Note cc: Michael] > > Ryan Harper writes: > > > This patch series decouples the detachment of a block device from the > > removal > > of the backing pci-device. Removal of a hotplugged pci device requires the > > guest to respond before qemu tears do

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-10-29 Thread Markus Armbruster
[Note cc: Michael] Ryan Harper writes: > This patch series decouples the detachment of a block device from the removal > of the backing pci-device. Removal of a hotplugged pci device requires the > guest to respond before qemu tears down the block device. In some cases, the > guest may not resp

[Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-10-25 Thread Ryan Harper
This patch series decouples the detachment of a block device from the removal of the backing pci-device. Removal of a hotplugged pci device requires the guest to respond before qemu tears down the block device. In some cases, the guest may not respond leaving the guest with continued access to the