Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-19 Thread Peter Maydell
On 19 January 2016 at 07:27, Markus Armbruster wrote: > Peter Maydell writes: > >> On 11 January 2016 at 15:19, Daniel P. Berrange wrote: >>> I think even guest-agent code & tests could include it in order to >>> get clean includes, even if they don't use any of the QEMU functions >>> defined in

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-18 Thread Markus Armbruster
Peter Maydell writes: > On 11 January 2016 at 15:19, Daniel P. Berrange wrote: >> On Mon, Dec 07, 2015 at 04:23:42PM +, Peter Maydell wrote: >>> We've had some discussion previously (on list and IRC) about adding an >>> include of "qemu/osdep.h" to everything. The basic idea is that every >>

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-18 Thread Peter Maydell
On 18 January 2016 at 16:33, Peter Maydell wrote: > On 11 January 2016 at 15:19, Daniel P. Berrange wrote: >> On Mon, Dec 07, 2015 at 04:23:42PM +, Peter Maydell wrote: >>> We've had some discussion previously (on list and IRC) about adding an >>> include of "qemu/osdep.h" to everything. The

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-18 Thread Peter Maydell
On 11 January 2016 at 15:19, Daniel P. Berrange wrote: > On Mon, Dec 07, 2015 at 04:23:42PM +, Peter Maydell wrote: >> We've had some discussion previously (on list and IRC) about adding an >> include of "qemu/osdep.h" to everything. The basic idea is that every >> .c file should include "qemu

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-11 Thread Daniel P. Berrange
On Mon, Dec 07, 2015 at 04:23:42PM +, Peter Maydell wrote: > We've had some discussion previously (on list and IRC) about adding an > include of "qemu/osdep.h" to everything. The basic idea is that every > .c file should include "qemu/osdep.h" as its first include; then every > other header (an

Re: [Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2016-01-11 Thread Peter Maydell
Ping for review, please? thanks -- PMM On 7 December 2015 at 16:23, Peter Maydell wrote: > We've had some discussion previously (on list and IRC) about adding an > include of "qemu/osdep.h" to everything. The basic idea is that every > .c file should include "qemu/osdep.h" as its first include;

[Qemu-devel] [PATCH 0/3] clean-includes script to add osdep.h to everything

2015-12-07 Thread Peter Maydell
We've had some discussion previously (on list and IRC) about adding an include of "qemu/osdep.h" to everything. The basic idea is that every .c file should include "qemu/osdep.h" as its first include; then every other header (and the .c file itself) can rely on the facilities that osdep.h provides.