Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-25 Thread Ryan Harper
* Christoph Hellwig [2011-08-24 13:46]: > On Mon, Aug 22, 2011 at 11:46:00AM -0500, Ryan Harper wrote: > > So, I believe this is how it's happening. > > > > we start accounting on a write which is turned into a multiwrite via > > virtio_blk_handle_write() which calls virtio_submit_multiwrite(). >

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-24 Thread Christoph Hellwig
On Mon, Aug 22, 2011 at 11:46:00AM -0500, Ryan Harper wrote: > So, I believe this is how it's happening. > > we start accounting on a write which is turned into a multiwrite via > virtio_blk_handle_write() which calls virtio_submit_multiwrite(). > > Then when the multiwrite completes, we invoke v

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Ryan Harper
* Christoph Hellwig [2011-08-22 10:37]: > On Mon, Aug 22, 2011 at 10:29:11AM -0500, Ryan Harper wrote: > > (gdb) frame 0 > > #0 0x004200c1 in bdrv_acct_done (bs=0x12310b0, cookie=0x1c68810) > > at /root/git/qemu/block_int.h:239 239 bs->nr_bytes[cookie->type] += > > cookie->bytes

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Kevin Wolf
Am 22.08.2011 00:25, schrieb Christoph Hellwig: > changes since V1: > - rebase to apply against the current qemu.git tree Applied patch 1, commented on patch 2. The third one looks good, but doesn't apply without the other one. Kevin

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Christoph Hellwig
On Mon, Aug 22, 2011 at 10:29:11AM -0500, Ryan Harper wrote: > (gdb) frame 0 > #0 0x004200c1 in bdrv_acct_done (bs=0x12310b0, cookie=0x1c68810) at > /root/git/qemu/block_int.h:239 239 bs->nr_bytes[cookie->type] += > cookie->bytes; > (gdb) p *cookie > $3 = {bytes = 720575897597378

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Ryan Harper
* Christoph Hellwig [2011-08-22 10:16]: > On Mon, Aug 22, 2011 at 09:59:16AM -0500, Ryan Harper wrote: > > * Christoph Hellwig [2011-08-21 17:27]: > > > changes since V1: > > > - rebase to apply against the current qemu.git tree > > > > > > Testing on tip + this series with: > > > > ./configu

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Christoph Hellwig
On Mon, Aug 22, 2011 at 09:59:16AM -0500, Ryan Harper wrote: > * Christoph Hellwig [2011-08-21 17:27]: > > changes since V1: > > - rebase to apply against the current qemu.git tree > > > Testing on tip + this series with: > > ./configure --enable-debug --enable-kvm --enable-io-thread > --targ

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Ryan Harper
* Christoph Hellwig [2011-08-21 17:27]: > changes since V1: > - rebase to apply against the current qemu.git tree Testing on tip + this series with: ./configure --enable-debug --enable-kvm --enable-io-thread --target-list=x86_64-softmmu x86_64-softmmu/qemu-system-x86_64 --enable-kvm -L pc-bi

Re: [Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-22 Thread Stefan Hajnoczi
On Mon, Aug 22, 2011 at 12:25:47AM +0200, Christoph Hellwig wrote: > changes since V1: > - rebase to apply against the current qemu.git tree Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 0/3] better I/O accounting V2

2011-08-21 Thread Christoph Hellwig
changes since V1: - rebase to apply against the current qemu.git tree