Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-19 Thread malc
On Mon, 19 Sep 2011, Juan Quintela wrote: > malc wrote: > > On Sun, 18 Sep 2011, Juan Quintela wrote: > > > >> malc wrote: > >> > On Fri, 16 Sep 2011, Anthony Liguori wrote: > >> > > >> >> Reviewed-by: Anthony Liguori > >> >> > >> >> malc, please Ack. > >> >> > >> > > >> > I don't like the co

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-19 Thread Juan Quintela
malc wrote: > On Sun, 18 Sep 2011, Juan Quintela wrote: > >> malc wrote: >> > On Fri, 16 Sep 2011, Anthony Liguori wrote: >> > >> >> Reviewed-by: Anthony Liguori >> >> >> >> malc, please Ack. >> >> >> > >> > I don't like the commit message. >> >> Can you be more specific? > > QEMUFile predate

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-18 Thread malc
On Sun, 18 Sep 2011, Juan Quintela wrote: > malc wrote: > > On Fri, 16 Sep 2011, Anthony Liguori wrote: > > > >> Reviewed-by: Anthony Liguori > >> > >> malc, please Ack. > >> > > > > I don't like the commit message. > > Can you be more specific? QEMUFile predates migration by a few years so

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-18 Thread Juan Quintela
malc wrote: > On Fri, 16 Sep 2011, Anthony Liguori wrote: > >> Reviewed-by: Anthony Liguori >> >> malc, please Ack. >> > > I don't like the commit message. Can you be more specific? Can you say what you will preffer? >> On 09/13/2011 07:52 AM, Juan Quintela wrote: >> > Hi >> > >> > QEMUFil

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-16 Thread malc
On Fri, 16 Sep 2011, Anthony Liguori wrote: > Reviewed-by: Anthony Liguori > > malc, please Ack. > I don't like the commit message. > > > On 09/13/2011 07:52 AM, Juan Quintela wrote: > > Hi > > > > QEMUFile is intended to be used only for migration. Change the other > > three users to use

Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-16 Thread Anthony Liguori
Reviewed-by: Anthony Liguori malc, please Ack. Regards, Anthony Liguori On 09/13/2011 07:52 AM, Juan Quintela wrote: Hi QEMUFile is intended to be used only for migration. Change the other three users to use FILE * operations directly. gcc on Fedora 15 complains about fread/write not che

[Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

2011-09-13 Thread Juan Quintela
Hi QEMUFile is intended to be used only for migration. Change the other three users to use FILE * operations directly. gcc on Fedora 15 complains about fread/write not checking its return value, so I added checks. But in several places only print an error message (there is no error handly that