Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-17 Thread Stefan Hajnoczi
On Mon, Jan 16, 2017 at 04:03:28PM -0500, Doug Goldstein wrote: > On 1/16/17 5:46 AM, Stefan Hajnoczi wrote: > > On Fri, Jan 13, 2017 at 09:15:49AM -0600, Doug Goldstein wrote: > >> On 1/13/17 6:02 AM, Stefan Hajnoczi wrote: > >>> On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > >>

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-16 Thread Michael S. Tsirkin
On Mon, Jan 16, 2017 at 04:03:28PM -0500, Doug Goldstein wrote: > On 1/16/17 5:46 AM, Stefan Hajnoczi wrote: > > On Fri, Jan 13, 2017 at 09:15:49AM -0600, Doug Goldstein wrote: > >> On 1/13/17 6:02 AM, Stefan Hajnoczi wrote: > >>> On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > >>

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-16 Thread Laszlo Ersek
On 01/12/17 12:46, Stefan Hajnoczi wrote: > The virtio_queue_set_notification() nesting introduced for AioContext polling > raised an assertion with virtio-net (even in non-polling mode). Converting > virtio-net and virtio-crypto to use virtio_queue_set_notification() in a > nesting fashion would

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-16 Thread Doug Goldstein
On 1/16/17 5:46 AM, Stefan Hajnoczi wrote: > On Fri, Jan 13, 2017 at 09:15:49AM -0600, Doug Goldstein wrote: >> On 1/13/17 6:02 AM, Stefan Hajnoczi wrote: >>> On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > The virtio_queue_set_n

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-16 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 09:15:49AM -0600, Doug Goldstein wrote: > On 1/13/17 6:02 AM, Stefan Hajnoczi wrote: > > On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > >> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > >>> The virtio_queue_set_notification() nesting introduced for AioContex

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Richard Henderson
On 01/12/2017 03:46 AM, Stefan Hajnoczi wrote: The virtio_queue_set_notification() nesting introduced for AioContext polling raised an assertion with virtio-net (even in non-polling mode). Converting virtio-net and virtio-crypto to use virtio_queue_set_notification() in a nesting fashion would b

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Doug Goldstein
On 1/13/17 6:02 AM, Stefan Hajnoczi wrote: > On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: >> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: >>> The virtio_queue_set_notification() nesting introduced for AioContext >>> polling >>> raised an assertion with virtio-net (even in non-poll

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Doug Goldstein
On 1/12/17 2:05 PM, Michael S. Tsirkin wrote: > On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: >> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: >>> The virtio_queue_set_notification() nesting introduced for AioContext >>> polling >>> raised an assertion with virtio-net (even in non-p

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-13 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > > The virtio_queue_set_notification() nesting introduced for AioContext > > polling > > raised an assertion with virtio-net (even in non-polling mode). Converting > > virtio-net and virt

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-12 Thread Michael S. Tsirkin
On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > > The virtio_queue_set_notification() nesting introduced for AioContext > > polling > > raised an assertion with virtio-net (even in non-polling mode). Converting > > virtio-net and virt

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-12 Thread Doug Goldstein
On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > The virtio_queue_set_notification() nesting introduced for AioContext polling > raised an assertion with virtio-net (even in non-polling mode). Converting > virtio-net and virtio-crypto to use virtio_queue_set_notification() in a > nesting fashion would

[Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-12 Thread Stefan Hajnoczi
The virtio_queue_set_notification() nesting introduced for AioContext polling raised an assertion with virtio-net (even in non-polling mode). Converting virtio-net and virtio-crypto to use virtio_queue_set_notification() in a nesting fashion would be invasive and isn't worth it. Patch 1 contains