Re: [Qemu-devel] [PATCH 0/2] tcg: fix TLB miss check in get_page_addr_code()

2018-06-29 Thread Richard Henderson
On 06/29/2018 09:21 AM, Peter Maydell wrote: > In commit 71b9a45330fe220d1 we changed the condition we use to > determine whether we need to refill the TLB in get_page_addr_code() to > if (unlikely(env->tlb_table[mmu_idx][index].addr_code != > (addr & (TARGET_PAGE_MASK

[Qemu-devel] [PATCH 0/2] tcg: fix TLB miss check in get_page_addr_code()

2018-06-29 Thread Peter Maydell
In commit 71b9a45330fe220d1 we changed the condition we use to determine whether we need to refill the TLB in get_page_addr_code() to if (unlikely(env->tlb_table[mmu_idx][index].addr_code != (addr & (TARGET_PAGE_MASK | TLB_INVALID_MASK { This isn't the right check