Re: [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage

2017-02-07 Thread P J P
+-- On Tue, 7 Feb 2017, Alistair Francis wrote --+ | > === | > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c | > index d921423..7f3d547 100644 | > --- a/hw/sd/sdhci.c | > +++ b/hw/sd/sdhci.c | > @@ -1019,7 +1019,11 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, | > unsigned size) | >

Re: [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage

2017-02-07 Thread Alistair Francis
On Tue, Feb 7, 2017 at 11:12 AM, P J P wrote: > +-- On Tue, 7 Feb 2017, Peter Maydell wrote --+ > | On 31 January 2017 at 12:24, P J P wrote: > | > In SDHCI emulation, the 'Block Count Enable' bit of the Transfer Mode > | > register is used to control 's->blkcnt' value. One, this bit is not > | >

Re: [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage

2017-02-07 Thread P J P
+-- On Tue, 7 Feb 2017, Peter Maydell wrote --+ | On 31 January 2017 at 12:24, P J P wrote: | > In SDHCI emulation, the 'Block Count Enable' bit of the Transfer Mode | > register is used to control 's->blkcnt' value. One, this bit is not | > relevant in single block transfers. Second, Transfer Mod

Re: [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage

2017-02-07 Thread Peter Maydell
On 31 January 2017 at 12:24, P J P wrote: > From: Prasad J Pandit > > Hello, > > In SDHCI emulation, the 'Block Count Enable' bit of the Transfer Mode > register is used to control 's->blkcnt' value. One, this bit is not > relevant in single block transfers. Second, Transfer Mode register > value

Re: [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage

2017-02-05 Thread P J P
+-- On Tue, 31 Jan 2017, P J P wrote --+ | In SDHCI emulation, the 'Block Count Enable' bit of the Transfer Mode | register is used to control 's->blkcnt' value. One, this bit is not | relevant in single block transfers. Second, Transfer Mode register | value could be set such that 's->blkcnt' woul

[Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage

2017-01-31 Thread P J P
From: Prasad J Pandit Hello, In SDHCI emulation, the 'Block Count Enable' bit of the Transfer Mode register is used to control 's->blkcnt' value. One, this bit is not relevant in single block transfers. Second, Transfer Mode register value could be set such that 's->blkcnt' would not see an upda