Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Stefan Hajnoczi
On Mon, Feb 03, 2014 at 10:30:08AM +, Peter Maydell wrote: > On 3 February 2014 09:54, Stefan Hajnoczi wrote: > > I still think we should merge these patches :). Are you happy to merge > > them? > > They look like they're fixing a bug to me, so yes. You could > make my life easier by arrangi

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Peter Maydell
On 3 February 2014 11:10, Andreas Färber wrote: > As an explanation, the temporary files contain the PID. When they remain > behind due to test failure *and* the PID wraps around and file names > thus happen to match, the error was triggered, and thereby not on each > run but seemingly "sometimes"

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Andreas Färber
Am 03.02.2014 10:54, schrieb Stefan Hajnoczi: > On Fri, Jan 31, 2014 at 12:07:34AM +, Peter Maydell wrote: >> On 21 November 2013 11:03, Stefan Hajnoczi wrote: >>> GLib uses abort(3) to exit failed test cases. As a result, the pid file and >>> UNIX domain sockets for a running test are leaked

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Peter Maydell
On 3 February 2014 09:54, Stefan Hajnoczi wrote: > I still think we should merge these patches :). Are you happy to merge > them? They look like they're fixing a bug to me, so yes. You could make my life easier by arranging for them to appear in a pull request... thanks -- PMM

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2014 at 12:07:34AM +, Peter Maydell wrote: > On 21 November 2013 11:03, Stefan Hajnoczi wrote: > > GLib uses abort(3) to exit failed test cases. As a result, the pid file and > > UNIX domain sockets for a running test are leaked upon failure. > > > > Since abort(3) does not ca

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-02-03 Thread Gerd Hoffmann
Hi, > > ERROR:/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:71:init_socket: > > assertion failed (ret != -1): (-1 != -1) > > FAIL > > GTester: last random seed: R02S79ea313790bc9a8b21d9af5ed55c2fff > > (pid=5080) > > /i386/qom/pc:

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-01-31 Thread Stefan Hajnoczi
On Fri, Jan 31, 2014 at 1:07 AM, Peter Maydell wrote: > On 21 November 2013 11:03, Stefan Hajnoczi wrote: >> GLib uses abort(3) to exit failed test cases. As a result, the pid file and >> UNIX domain sockets for a running test are leaked upon failure. >> >> Since abort(3) does not call atexit(3)

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2014-01-30 Thread Peter Maydell
On 21 November 2013 11:03, Stefan Hajnoczi wrote: > GLib uses abort(3) to exit failed test cases. As a result, the pid file and > UNIX domain sockets for a running test are leaked upon failure. > > Since abort(3) does not call atexit(3) handler functions, we could set up a > SIGABRT handler that

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2013-12-06 Thread Markus Armbruster
Stefan Hajnoczi writes: > GLib uses abort(3) to exit failed test cases. As a result, the pid file and > UNIX domain sockets for a running test are leaked upon failure. > > Since abort(3) does not call atexit(3) handler functions, we could set up a > SIGABRT handler that performs cleanup. But th

Re: [Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2013-12-05 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 12:03:53PM +0100, Stefan Hajnoczi wrote: > GLib uses abort(3) to exit failed test cases. As a result, the pid file and > UNIX domain sockets for a running test are leaked upon failure. > > Since abort(3) does not call atexit(3) handler functions, we could set up a > SIGABR

[Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2013-11-21 Thread Stefan Hajnoczi
GLib uses abort(3) to exit failed test cases. As a result, the pid file and UNIX domain sockets for a running test are leaked upon failure. Since abort(3) does not call atexit(3) handler functions, we could set up a SIGABRT handler that performs cleanup. But there are other conditions where proc