Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Sun, Mar 10, 2013 at 12:15:11PM -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 12:13 -0600, Alex Williamson wrote: > > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > > > Rather than have everyone call

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Sun, Mar 10, 2013 at 12:13:27PM -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > > Rather than have everyone call pci_bridge_map_irq() themselves and > > > come up with incorrect

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Alex Williamson
On Sun, 2013-03-10 at 12:13 -0600, Alex Williamson wrote: > On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > > Rather than have everyone call pci_bridge_map_irq() themselves and > > > come up with incorrect mapping

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Alex Williamson
On Sun, 2013-03-10 at 18:16 +0200, Michael S. Tsirkin wrote: > On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > > Rather than have everyone call pci_bridge_map_irq() themselves and > > come up with incorrect mapping functions let's use the default PCI > > defined swizzle function

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate fu

Re: [Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-10 Thread Michael S. Tsirkin
On Thu, Mar 07, 2013 at 04:16:48PM -0700, Alex Williamson wrote: > Rather than have everyone call pci_bridge_map_irq() themselves and > come up with incorrect mapping functions let's use the default PCI > defined swizzle function unless told otherwise. Then we can also > clean out the duplicate fu

[Qemu-devel] [PATCH 0/2] pci_bridge: Fixup/Cleanup bridge map_irq functions

2013-03-07 Thread Alex Williamson
Rather than have everyone call pci_bridge_map_irq() themselves and come up with incorrect mapping functions let's use the default PCI defined swizzle function unless told otherwise. Then we can also clean out the duplicate function in pci_bridge_dev. Tested with an assigned device behind a PCIe s