Re: [Qemu-devel] [PATCH 0/2] block: Do OFD lock check at runtime

2017-07-21 Thread Daniel P. Berrange
On Fri, Jul 21, 2017 at 07:34:11AM -0500, Eric Blake wrote: > On 07/21/2017 06:56 AM, Kevin Wolf wrote: > >> > >> Convert to runtime check to cope with that. > > > > Fair enough in this specific case because we still support older Linux > > kernels and we want to fail gracefully if the binary was

Re: [Qemu-devel] [PATCH 0/2] block: Do OFD lock check at runtime

2017-07-21 Thread Eric Blake
On 07/21/2017 06:56 AM, Kevin Wolf wrote: >> >> Convert to runtime check to cope with that. > > Fair enough in this specific case because we still support older Linux > kernels and we want to fail gracefully if the binary was built against > a newer kernel. Or, more likely: if we are built agains

Re: [Qemu-devel] [PATCH 0/2] block: Do OFD lock check at runtime

2017-07-21 Thread Kevin Wolf
Am 21.07.2017 um 12:20 hat Fam Zheng geschrieben: > This fixes the image opening failure reported by Andrew Baumann: > > > I'm running a recent Linux build of qemu on Windows Subsystem for Linux > > (WSL) > > which doesn't appear to implement file locking: > > > > $ qemu-system-aarch64 ... -drive

[Qemu-devel] [PATCH 0/2] block: Do OFD lock check at runtime

2017-07-21 Thread Fam Zheng
This fixes the image opening failure reported by Andrew Baumann: > I'm running a recent Linux build of qemu on Windows Subsystem for Linux (WSL) > which doesn't appear to implement file locking: > > $ qemu-system-aarch64 ... -drive file=test.vhdx,if=none,id=hd0 -device > virtio-blk-pci,drive=hd0