Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-22 Thread Anthony Liguori
On 08/11/2011 02:40 AM, Avi Kivity wrote: The memory API automatically cracks wide memory accesses into narrower (usually byte) accesses when needed. Unfortunately this wasn't implemented for ioports, leading to an lsi53c895a failure. This series implements cracking for ioports as well. Note t

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-22 Thread Avi Kivity
On 08/11/2011 10:01 PM, Gerhard Wiesinger wrote: On Thu, 11 Aug 2011, Avi Kivity wrote: Or maybe it's just -O2 screwing up debug information. Please change ./configure to set -O1 and redo. Please print *r.memory as well. ./configure --target-list=x86_64-softmmu,i386-softmmu --enable-debug R

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: Or maybe it's just -O2 screwing up debug information. Please change ./configure to set -O1 and redo. Please print *r.memory as well. ./configure --target-list=x86_64-softmmu,i386-softmmu --enable-debug Rest below. Ciao, Gerhard -- http://www.wiesinger

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:20 PM, Avi Kivity wrote: On 08/11/2011 07:08 PM, Gerhard Wiesinger wrote: (gdb) frame 4 #4 0x0041eb9b in pci_update_mappings (d=0x1a90bc0) at /root/download/qemu/git/qemu-kvm-test/hw/pci.c:1134 1134memory_region_del_subregion(r->address_space, r->m

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:08 PM, Gerhard Wiesinger wrote: (gdb) frame 4 #4 0x0041eb9b in pci_update_mappings (d=0x1a90bc0) at /root/download/qemu/git/qemu-kvm-test/hw/pci.c:1134 1134memory_region_del_subregion(r->address_space, r->memory); (gdb) print i $1 = (gdb) print *r

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 07:11 PM, Gerhard Wiesinger wrote: On Thu, 11 Aug 2011, Avi Kivity wrote: This should be faster today with really new kernels (the problem is not in qemu) but I'm not sure if it's fast enough. What's a "really new" kernel? In which version were performance optimizations done? (C

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: This should be faster today with really new kernels (the problem is not in qemu) but I'm not sure if it's fast enough. What's a "really new" kernel? In which version were performance optimizations done? (Currently I'm using 2.6.34.7, hadn't time yet to u

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
On Thu, 11 Aug 2011, Avi Kivity wrote: On 08/11/2011 12:01 PM, Gerhard Wiesinger wrote: Hello Avi, #0 0x003a060328f5 in raise () from /lib64/libc.so.6 #1 0x003a060340d5 in abort () from /lib64/libc.so.6 #2 0x003a0602b8b5 in __assert_fail () from /lib64/libc.so.6 #3 0x00

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 12:01 PM, Gerhard Wiesinger wrote: Hello Avi, #0 0x003a060328f5 in raise () from /lib64/libc.so.6 #1 0x003a060340d5 in abort () from /lib64/libc.so.6 #2 0x003a0602b8b5 in __assert_fail () from /lib64/libc.so.6 #3 0x00435339 in memory_region_del_subregion (mr

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
Hello Avi, #0 0x003a060328f5 in raise () from /lib64/libc.so.6 #1 0x003a060340d5 in abort () from /lib64/libc.so.6 #2 0x003a0602b8b5 in __assert_fail () from /lib64/libc.so.6 #3 0x00435339 in memory_region_del_subregion (mr=, subregion=)at /root/download/qemu/git/qem

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 11:27 AM, Avi Kivity wrote: On 08/11/2011 11:25 AM, Gerhard Wiesinger wrote: Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
On 08/11/2011 11:25 AM, Gerhard Wiesinger wrote: Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region_del_subregion: Assertion `subregion->paren

Re: [Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Gerhard Wiesinger
Hello Avi, Thank for the fast fix. Unfortunatly it still doesn't work (but LSI BIOS is initialized correctly). I'm getting at boot time: qemu-system-x86_64: /qemu-kvm-test/memory.c:1168: memory_region_del_subregion: Assertion `subregion->parent == mr' failed. Thnx. Ciao, Gerhard -- http:/

[Qemu-devel] [PATCH 0/2] Fix wide ioport access cracking

2011-08-11 Thread Avi Kivity
The memory API automatically cracks wide memory accesses into narrower (usually byte) accesses when needed. Unfortunately this wasn't implemented for ioports, leading to an lsi53c895a failure. This series implements cracking for ioports as well. Note that the dual implementation is due to the fa