Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-05 Thread Daniel P . Berrangé
On Fri, Oct 05, 2018 at 02:57:03PM +0200, Dominik Csapak wrote: > On 10/5/18 10:38 AM, Daniel P. Berrangé wrote: > > On Fri, Oct 05, 2018 at 08:56:27AM +0200, Dominik Csapak wrote: > > > On 10/4/18 3:51 PM, Daniel P. Berrangé wrote: > > > > On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak w

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-05 Thread Dominik Csapak
On 10/5/18 10:38 AM, Daniel P. Berrangé wrote: On Fri, Oct 05, 2018 at 08:56:27AM +0200, Dominik Csapak wrote: On 10/4/18 3:51 PM, Daniel P. Berrangé wrote: On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak wrote: this patch aims to execute a script when qemu exits so that one can do cl

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-05 Thread Daniel P . Berrangé
On Fri, Oct 05, 2018 at 08:56:27AM +0200, Dominik Csapak wrote: > On 10/4/18 3:51 PM, Daniel P. Berrangé wrote: > > On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak wrote: > > > this patch aims to execute a script when qemu exits > > > so that one can do cleanups when using --daemonize with

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-05 Thread Dominik Csapak
On 10/4/18 3:51 PM, Daniel P. Berrangé wrote: On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak wrote: this patch aims to execute a script when qemu exits so that one can do cleanups when using --daemonize without having to use the qmp monitor IMHO the idea of cleanup scripts run by QEM

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-04 Thread Daniel P . Berrangé
On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak wrote: > this patch aims to execute a script when qemu exits > so that one can do cleanups when using --daemonize without > having to use the qmp monitor IMHO the idea of cleanup scripts run by QEMU itself is flawed. QEMU will inevitably cra

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-03 Thread Philippe Mathieu-Daudé
Hi Dominik, On 03/10/2018 11:13, Dominik Csapak wrote: > this patch aims to execute a script when qemu exits > so that one can do cleanups when using --daemonize without > having to use the qmp monitor > > for now i have mostly copied the script execution code from > the launch_script function of

[Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-03 Thread Dominik Csapak
this patch aims to execute a script when qemu exits so that one can do cleanups when using --daemonize without having to use the qmp monitor for now i have mostly copied the script execution code from the launch_script function of net/tap.c as i am not sure if it would make sense to refactor that