Re: [Qemu-devel] [PATCH] xen_console: support the new extended xenstore protocol

2011-06-28 Thread Stefano Stabellini
On Tue, 28 Jun 2011, Peter Maydell wrote: > On 28 June 2011 12:34, wrote: > > +    path = xs_get_domain_path(xs, domid); > > +    if (path == NULL) { > > +        fprintf(stderr, "xs_get_domain_path() error\n"); > > +        return -1; > > +    } > > Don't we need to call xs_daemon_close() on th

Re: [Qemu-devel] [PATCH] xen_console: support the new extended xenstore protocol

2011-06-28 Thread Peter Maydell
On 28 June 2011 12:34, wrote: > +    path = xs_get_domain_path(xs, domid); > +    if (path == NULL) { > +        fprintf(stderr, "xs_get_domain_path() error\n"); > +        return -1; > +    } Don't we need to call xs_daemon_close() on these error-exit paths? > +    if (!xs_write(xs, XBT_NULL,

[Qemu-devel] [PATCH] xen_console: support the new extended xenstore protocol

2011-06-28 Thread stefano.stabellini
From: Stefano Stabellini Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore protocol, as described by the document docs/misc/console.txt under xen-unstable.hg. >From the Qemu poin