Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Paolo Bonzini
On 16/02/2017 14:27, Alexander Boettcher wrote: > On 16.02.2017 13:57, Paolo Bonzini wrote: >> >> >> On 16/02/2017 13:57, Alexander Boettcher wrote: >>> Hello Paolo, >>> >>> On 16.02.2017 12:53, Paolo Bonzini wrote: As you noticed, the problem is that now cpu_vmexit is called without a

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Alexander Boettcher
On 16.02.2017 13:57, Paolo Bonzini wrote: > > > On 16/02/2017 13:57, Alexander Boettcher wrote: >> Hello Paolo, >> >> On 16.02.2017 12:53, Paolo Bonzini wrote: >>> As you noticed, the problem is that now cpu_vmexit is called without a >>> cpu_restore_state before. >>> >>> The right fix is to pass

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Paolo Bonzini
On 16/02/2017 13:57, Alexander Boettcher wrote: > Hello Paolo, > > On 16.02.2017 12:53, Paolo Bonzini wrote: >> As you noticed, the problem is that now cpu_vmexit is called without a >> cpu_restore_state before. >> >> The right fix is to pass the retaddr to cpu_vmexit (via >> cpu_svm_check_inter

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Alexander Boettcher
Hello Paolo, On 16.02.2017 12:53, Paolo Bonzini wrote: > As you noticed, the problem is that now cpu_vmexit is called without a > cpu_restore_state before. > > The right fix is to pass the retaddr to cpu_vmexit (via > cpu_svm_check_intercept_param); something like this untested patch: ... > >

Re: [Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Paolo Bonzini
> Hello, > > I have a short question/observation and a longer story. > > Short question: > > Between qemu 2.4.1 and 2.5.0 following snippet of code vanished: > > --- qemu-2.4.1/target-i386/mem_helper.c > +++ qemu-2.5.0/target-i386/mem_helper.c > @@ -122,11 +142,7 @@ > X86CPU *cpu = X86

[Qemu-devel] [PATCH] x86 tlb_fill in memory_helper.c

2017-02-16 Thread Alexander Boettcher
Hello, I have a short question/observation and a longer story. Short question: Between qemu 2.4.1 and 2.5.0 following snippet of code vanished: --- qemu-2.4.1/target-i386/mem_helper.c +++ qemu-2.5.0/target-i386/mem_helper.c @@ -122,11 +142,7 @@ X86CPU *cpu = X86_CPU(cs); CPUX8